Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduction.md: Add links to resources. #29327

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pisethTang
Copy link

@pisethTang pisethTang commented Jan 16, 2025

Added 4 URLs to additional resources: 3 online tutorials and 1 book.

Because

There were no additional resources for this lesson.

This PR

  • Added 4 URLs to additional resources: 3 online tutorials and 1 book.

Issue

Closes #XXXXX

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

Added 4 links to additional resources: 3 online tutorials and 1 book.
@github-actions github-actions bot added the Content: Intermediate HTML/CSS Involves the Intermediate HTML/CSS course label Jan 16, 2025
Note: Online tutorial.
- [W3Schools CSS Tutorial](https://www.w3schools.com/css/)
Note: Online tutorial.
- [MDN Web Docs](https://developer.mozilla.org/en-US/)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't name this as a tutorial. I would change it to "HTML documentation" instead of "Online tutorial". Just so it's a bit clearer.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, it is my first time contributing to an open-source project. I agree that the "MDN Web Docs" is not an online tutorial and should be changed to something like "Documentation for HTML". However, if we clicked on the first 2 links to W3Schools, we would see the term "tutorial" on both sites. So should I also change them to "HTML Documentation" and "CSS Documentation", respectively, as well?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We wouldn't really need the notes, IMHO. The link text labels, when amended accordingly, should be sufficient by themselves (the current formatting of the Note: line would trigger lint errors anyway, and isn't like how any other additional resources are formatted in the curriculum).

Note: Online tutorial.
- [MDN Web Docs](https://developer.mozilla.org/en-US/)
Note: Online tutorial.
- [Learning Web Design A Beginner's Guide to HTML, CSS, JavaScript, and Web Graphics](https://wtf.tw/ref/robbins.pdf)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at it's a pretty long book. I would see this as more of an end of the intermediate section type of resource. If you could remove the book and address the other note I would be happy to merge it.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'd be happy to do that.

Copy link
Contributor

@linkonsat linkonsat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted some minor changes that would be beneficial. If you could change them I would be fine with merging it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: Intermediate HTML/CSS Involves the Intermediate HTML/CSS course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants