-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
introduction.md: Add links to resources. #29327
base: main
Are you sure you want to change the base?
Conversation
Added 4 links to additional resources: 3 online tutorials and 1 book.
Note: Online tutorial. | ||
- [W3Schools CSS Tutorial](https://www.w3schools.com/css/) | ||
Note: Online tutorial. | ||
- [MDN Web Docs](https://developer.mozilla.org/en-US/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't name this as a tutorial. I would change it to "HTML documentation" instead of "Online tutorial". Just so it's a bit clearer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, it is my first time contributing to an open-source project. I agree that the "MDN Web Docs" is not an online tutorial and should be changed to something like "Documentation for HTML". However, if we clicked on the first 2 links to W3Schools, we would see the term "tutorial" on both sites. So should I also change them to "HTML Documentation" and "CSS Documentation", respectively, as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We wouldn't really need the notes, IMHO. The link text labels, when amended accordingly, should be sufficient by themselves (the current formatting of the Note:
line would trigger lint errors anyway, and isn't like how any other additional resources are formatted in the curriculum).
Note: Online tutorial. | ||
- [MDN Web Docs](https://developer.mozilla.org/en-US/) | ||
Note: Online tutorial. | ||
- [Learning Web Design A Beginner's Guide to HTML, CSS, JavaScript, and Web Graphics](https://wtf.tw/ref/robbins.pdf) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at it's a pretty long book. I would see this as more of an end of the intermediate section type of resource. If you could remove the book and address the other note I would be happy to merge it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I'd be happy to do that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted some minor changes that would be beneficial. If you could change them I would be fine with merging it.
Added 4 URLs to additional resources: 3 online tutorials and 1 book.
Because
There were no additional resources for this lesson.
This PR
Issue
Closes #XXXXX
Additional Information
Pull Request Requirements
location of change: brief description of change
format, e.g.Intro to HTML and CSS lesson: Fix link text
Because
section summarizes the reason for this PRThis PR
section has a bullet point list describing the changes in this PRIssue
section