fix: do not return incomplete search results #224
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olevski
force-pushed
the
fix-remove-incompelete-search-results
branch
3 times, most recently
from
65a7d41 to
6c28d35
Compare
|
The namespace can be null, because there are events that don't send it. I think we should either remove the v1 or we should allow optional namespaces. UI should be able to deal with it, it could filter it out for example. |
|
@eikek yeah I had removed all the v1 events in another PR - I did not do it in this one. I will remove the v1 events here. They are not needed at this point. |
|
And I definitely understand why the namespaces could be null. |
|
@eikek it is actually better to open a separate PR for the v1 events removal. So I will do that later this week. |
olevski
force-pushed
the
fix-remove-incompelete-search-results
branch
from
6c28d35 to
7dff8e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.