Filter invalid search results #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eikek
force-pushed
the
filter-invalid-search-results
branch
2 times, most recently
from
363899f to
6fed0d8
Compare
eikek
force-pushed
the
filter-invalid-search-results
branch
5 times, most recently
from
7d1dbbc to
c91d8c2
Compare
eikek
changed the title
This will select only entities, where a `namespace` property exists. Additionally, it selects only projects that have an existing `createBy` property. This doesn't filter out results, where a subquery would return no results.
A namespace is a reference to another entity. If this doesn't exist, the results are not valid and are therefore not selected to be returned from a user query
eikek
force-pushed
the
filter-invalid-search-results
branch
from
c91d8c2 to
8538e1a
Compare
Panaetius
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements filtering for invalid results (where namespace doesn't exist or doesn't resolve to an existing namespace entity). It uses an additional solr "filter query", closes #224 therefore as well.