Ensure dismiss action for AccountSetupSheet is anchored correctly #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19 +/- ##
==========================================
- Coverage 79.57% 79.56% -0.01%
==========================================
Files 38 40 +2
Lines 1346 1360 +14
==========================================
+ Hits 1071 1082 +11
- Misses 275 278 +3
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
PSchmiedmayer
approved these changes
Jun 12, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure dismiss action for AccountSetupSheet is anchored correctly
♻️ Current situation & Problem
Fixes the issue described in #18, where the Account Setup sheet wouldn't disappear after successfully logging in.
Further this PR fixes the issue where the display name wouldn't be saved upon signup. This issue was fixed upstream in StanfordSpezi/SpeziFirebase#36.
⚙️ Release Notes
📚 Documentation
--
✅ Testing
UI test was added to verify the setup sheet is dismissed after login.
Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: