Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PDF Export] Add autotable plugin #26

Closed

Conversation

ThomasKaar
Copy link

[PDF Export] Add autotable plugin

♻️ Current situation & Problem

500 status code when calling the PDF export function locally, as reported in #25.

⚙️ Release Notes

  • Adding autotable plugin to generate.ts

📚 Documentation

I don't think further documentation is needed here (similar to PR #19 in ENGAGE-HF-iOS)

✅ Testing

Setting up the Firebase functions with:

$ npm install
$ cd functions; npm install
$ npm run serve
Before After
$ wget -O test.pdf http://127.0.0.1:5001/stanford-bdhg-engage-hf/us-central1/exportHealthSummary HTTP request sent, awaiting response... 500 Internal Server Error HTTP request sent, awaiting response... 200 OK test.pdf

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@pauljohanneskraft
Copy link
Collaborator

Thank you for your contributions. The issue should already be resolved on the health-summary-data branch (by using import 'jsPDF-autotable' though) which is about to be merged with #19.

Just a bit of context why this problem even exists: Apparently the linter automatically 'fixed' an issue by removing the import line, which is now prohibited to be removed by disabling the linter rule for that line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants