Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECHOES-493 Add check on .d.ts generation #223

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions docs/RELEASING.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,19 +23,19 @@ For more details, refer to the [internal versioning strategy](https://docs.googl

- Create a new branch for the release and maintenance following the name convention `branch-x.y`

- [Publish a new GitHub release](https://github.com/SonarSource/echoes-react/releases/new) targeting the release branch

- Find the relevant release from the [releases page](https://sonarsource.atlassian.net/projects/ECHOES?selectedItem=com.atlassian.jira.jira-projects-plugin%3Arelease-page) and populate (as markdown) the notes section.
- Example: <https://github.com/SonarSource/echoes-react/releases/tag/v0.5.0>
- click _Publish Release_

- [Create a Jira release ticket in the REL project](https://jira.sonarsource.com/projects/REL) like [this one](https://sonarsource.atlassian.net/jira/software/c/projects/REL/issues/REL-3062)

- Summary: @sonarsource/echoes-react x.y
- Documentation status: N/A
- Short description: pull from [version description](https://sonarsource.atlassian.net/projects/DS/versions/15439/tab/release-report-all-issues)
- Short description: pull from [version description](https://sonarsource.atlassian.net/projects/ECHOES/versions/15439/tab/release-report-all-issues)
- SQ compatibility: current version
- Link to Jira RELEASE NOTES: copy from a previous release ticket, updating the release ID, e.g.: <https://sonarsource.atlassian.net/projects/DS/versions/15590/tab/release-report-all-issues?isReleaseNoteModalOpen=true>

- [Publish a new GitHub release](https://github.com/SonarSource/echoes-react/releases/new) targeting the release branch

- Find the relevant release from the [releases page](https://sonarsource.atlassian.net/projects/DS?selectedItem=com.atlassian.jira.jira-projects-plugin%3Arelease-page) and populate (as markdown) the notes section.
- Example: <https://github.com/SonarSource/echoes-react/releases/tag/v0.5.0>
- click _Publish Release_
- Link to Jira RELEASE NOTES: copy from a previous release ticket, updating the release ID, e.g.: <https://sonarsource.atlassian.net/projects/ECHOES/versions/15590/tab/release-report-all-issues?isReleaseNoteModalOpen=true>

- Close the REL ticket you've created

Expand All @@ -51,7 +51,7 @@ For more details, refer to the [internal versioning strategy](https://docs.googl

- Create a PR on the version branch with the changes

- [Create a new version in the Echoes Design System project](https://sonarsource.atlassian.net/projects/DS?selectedItem=com.atlassian.jira.jira-projects-plugin%3Arelease-page) like [this one](https://sonarsource.atlassian.net/projects/DS/versions/15545)
- [Create a new version in the Echoes Design System project](https://sonarsource.atlassian.net/projects/ECHOES?selectedItem=com.atlassian.jira.jira-projects-plugin%3Arelease-page) like [this one](https://sonarsource.atlassian.net/projects/ECHOES/versions/15545)

- Tag the relevant tickets with this new version

Expand Down
4 changes: 3 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,9 @@
"lint-report": "eslint --ext js,ts,tsx,snap -f json -o build-reports/eslint-report/eslint-report.json .",
"storybook": "storybook dev -p 6006",
"tokens-check": "./config/scripts/validate-tokens.sh",
"ts-check": "tsc --noEmit",
"ts-check": "yarn ts-check-files && yarn ts-check-declarations",
"ts-check-files": "tsc --noEmit",
"ts-check-declarations": "tsc --noEmit false --emitDeclarationOnly --isolatedModules false --outFile ./build-reports/ts-declarations/all-declarations",
"validate": "yarn lint && yarn ts-check && yarn format-check",
"validate-ci": "yarn dep-check && yarn intl-keys-check && yarn tokens-check && yarn fonts-check && yarn lint-report && yarn ts-check && yarn format-check"
},
Expand Down
2 changes: 1 addition & 1 deletion src/components/dropdown-menu/DropdownMenuSubMenu.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import { IconChevronRight } from '../icons';
import { styleDropdownMenuOverlay } from './DropdownMenuCommons';
import { DropdownMenuItemBase } from './DropdownMenuItemBase';

interface DropdownMenuSubProps extends radixDropdownMenu.DropdownMenuSubProps {
export interface DropdownMenuSubProps extends radixDropdownMenu.DropdownMenuSubProps {
className?: string;
id?: string;
isOpen?: boolean;
Expand Down
Loading