Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECHOES-493 Add check on .d.ts generation #223

Merged

Conversation

david-cho-lerat-sonarsource
Copy link
Contributor

@david-cho-lerat-sonarsource david-cho-lerat-sonarsource commented Dec 16, 2024

Copy link

netlify bot commented Dec 16, 2024

Deploy Preview for echoes-react ready!

Name Link
🔨 Latest commit d324a4b
🔍 Latest deploy log https://app.netlify.com/sites/echoes-react/deploys/67600e9e78091100088edde6
😎 Deploy Preview https://deploy-preview-223--echoes-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
Copy link
Member

@gregaubert gregaubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! Just two possible improvements!

@david-cho-lerat-sonarsource david-cho-lerat-sonarsource force-pushed the david/ECHOES-493-add-check-on-d-ts-generation branch from 8556fff to d324a4b Compare December 16, 2024 11:27
Copy link

@david-cho-lerat-sonarsource david-cho-lerat-sonarsource merged commit 6d39153 into main Dec 16, 2024
14 checks passed
@david-cho-lerat-sonarsource david-cho-lerat-sonarsource deleted the david/ECHOES-493-add-check-on-d-ts-generation branch December 16, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants