Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(common): add common in 'mon-domifa' #3036

Merged
merged 3 commits into from
Nov 8, 2023

Conversation

pYassine
Copy link
Contributor

@pYassine pYassine commented Nov 8, 2023

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #3036 (24aec54) into master (f5b7894) will increase coverage by 0.06%.
The diff coverage is 60.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3036      +/-   ##
==========================================
+ Coverage   67.86%   67.93%   +0.06%     
==========================================
  Files         919      913       -6     
  Lines       14683    14585      -98     
  Branches     2113     2096      -17     
==========================================
- Hits         9965     9908      -57     
+ Misses       4444     4406      -38     
+ Partials      274      271       -3     
Files Coverage Δ
packages/backend/src/_common/model/usager/index.ts 100.00% <ø> (ø)
...rc/database/entities/usager/UsagerTable.typeorm.ts 100.00% <ø> (ø)
...s/_scripts/data-anonymizer/dataUsagerAnonymizer.ts 11.47% <ø> (ø)
...nderer/exportListeParticipantsWorksheetRenderer.ts 96.34% <100.00%> (-0.05%) ⬇️
...mport/step3-create/usagersImportBuilder.service.ts 96.05% <ø> (ø)
packages/backend/src/usagers/dto/decision.dto.ts 65.38% <100.00%> (ø)
...sagers/services/cerfa/generateCerfaData.service.ts 92.39% <100.00%> (ø)
...ers/services/custom-docs/buildCustomDoc.service.ts 69.23% <ø> (-0.24%) ⬇️
packages/backend/src/usagers/services/index.ts 100.00% <ø> (ø)
...rs/services/usagerVisibleHistoryManager.service.ts 14.28% <ø> (ø)
... and 14 more

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5b7894...24aec54. Read the comment docs.

Copy link

github-actions bot commented Nov 8, 2023

🎉 Deployment for commit e0a5c95 :

Ingresses
Docker images
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/backend:sha-e0a5c953ff2779e937d354c8a2fd07626bfe2118
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/frontend:sha-e0a5c953ff2779e937d354c8a2fd07626bfe2118
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-admins:sha-e0a5c953ff2779e937d354c8a2fd07626bfe2118
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-usagers:sha-e0a5c953ff2779e937d354c8a2fd07626bfe2118
Debug

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Copy link

sonarqubecloud bot commented Nov 8, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@pYassine pYassine merged commit 41b7d94 into master Nov 8, 2023
9 of 11 checks passed
@pYassine pYassine deleted the refactor-common-portail branch November 8, 2023 21:19
@SocialGroovyBot
Copy link
Member

🎉 This PR is included in version 2.142.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants