Skip to content

Commit

Permalink
fix(common): delete useless interfaces
Browse files Browse the repository at this point in the history
  • Loading branch information
pYassine committed Nov 8, 2023
1 parent 905021c commit 7d92134
Show file tree
Hide file tree
Showing 12 changed files with 21 additions and 45 deletions.
16 changes: 8 additions & 8 deletions .github/workflows/unit-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,18 +32,15 @@ jobs:
- name: Set up Yarn cache
uses: c-hive/gha-yarn-cache@v2

- name: Build common dependencies
run: yarn workspace @domifa/common build

- name: Test common dependencies
run: yarn workspace @domifa/common test

- name: Create backend .env file
run: cp ./packages/backend/.env.backend.test.local.example.env ./packages/backend/.env

- name: Install backend dependencies
run: yarn workspaces focus @domifa/backend

- name: Build common dependencies
run: yarn workspace @domifa/common build

- name: Create Postgres service
run: docker-compose -f ./docker-compose.tests.yml up --build --detach

Expand Down Expand Up @@ -121,7 +118,7 @@ jobs:
- name: Install dependencies
run: yarn workspaces focus @domifa/portail-usagers

- name: Run front-end tests
- name: Run "Mon DomiFa" tests
run: yarn workspace @domifa/portail-usagers test --coverage --detectOpenHandles --forceExit

- name: Archive code coverage
Expand All @@ -147,10 +144,13 @@ jobs:
- name: Set up Yarn cache
uses: c-hive/gha-yarn-cache@v2

- name: Build common dependencies
run: yarn workspace @domifa/common build

- name: Install dependencies
run: yarn workspaces focus @domifa/portail-admins

- name: Run front-end tests
- name: Run "Portail Admin" tests
run: yarn workspace @domifa/portail-admins test --coverage --detectOpenHandles --forceExit

- name: Archive code coverage
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ import {
UsagerTypeDom,
UsagerAyantDroit,
INTERACTIONS_IN,
getRdvInfos,
} from "@domifa/common";
import { getRdvInfos } from "@domifa/common";

export class UsagerFormModel {
public ref: number;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,13 @@ import {
USAGER_DECISION_STATUT_LABELS,
USAGER_DECISION_STATUT_COLORS,
INTERACTIONS_IN,
getRdvInfos,
} from "@domifa/common";
import { getEcheanceInfos } from "../../modules/usager-shared/utils";
import {
Options,
UsagerFormModel,
} from "../../modules/usager-shared/interfaces";
import { getRdvInfos } from "@domifa/common";

export const _usagerReducer = createReducer(
INITIAL_STATE,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { PortailUsagerProfile } from "./PortailUsagerProfile.type";

export type PortailUsagerAuthApiResponse = {
export interface PortailUsagerAuthApiResponse {
token: string;
profile: PortailUsagerProfile;
};
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
export interface PortailUsagerAuthLoginForm {
login: string;
password: string;
}

This file was deleted.

4 changes: 2 additions & 2 deletions packages/portail-usagers/src/_common/_portail-usager/index.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
export * from "./PortailUsagerAuthApiResponse.type";
export * from "./PortailUsagerAuthLoginForm.type";
export * from "./PortailUsagerAuthApiResponse.interface";
export * from "./PortailUsagerAuthLoginForm.interface";
export * from "./PortailUsagerProfile.type";
export * from "./PortailUsagerPublic.type";

This file was deleted.

This file was deleted.

This file was deleted.

3 changes: 0 additions & 3 deletions packages/portail-usagers/src/_common/usager/options/index.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,4 @@
//@index('./*', f => `export * from '${f.path}'`)
export * from "./UsagerOptions.type";
export * from "./UsagerOptionsHistory.type";
export * from "./UsagerOptionsHistoryAction.type";
export * from "./UsagerOptionsHistoryType.type";
export * from "./UsagerOptionsProcuration.type";
export * from "./UsagerOptionsTransfert.type";
6 changes: 3 additions & 3 deletions tech.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,13 @@ stack:
common:
- Typescript
frontend:
- Angular 13
- Angular 15
- Typescript
portail-admins:
- Angular 13
- Angular 15
- Typescript
portail-usagers:
- Angular 13
- Angular 15
- Typescript
backend:
- NestJS
Expand Down

0 comments on commit 7d92134

Please sign in to comment.