Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edits: 'edge-app run' open in browser #170

Merged
merged 8 commits into from
Jul 3, 2024
Merged

Edits: 'edge-app run' open in browser #170

merged 8 commits into from
Jul 3, 2024

Conversation

rusko124
Copy link
Contributor

@rusko124 rusko124 commented Jul 2, 2024

Ticket: https://phorge.wireload.net/T8681

Edits:

  • screenly edge-app run opens the URL in browser

It is tested only on Linux.

@rusko124 rusko124 marked this pull request as draft July 2, 2024 07:28
@rusko124 rusko124 marked this pull request as ready for review July 2, 2024 07:32
korvyashka
korvyashka approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@korvyashka korvyashka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests if possible, though I understand it could be complicated, so approving

@rusko124 rusko124 merged commit 1ffa4ea into master Jul 3, 2024
6 checks passed
@rusko124 rusko124 mentioned this pull request Jul 3, 2024
Closed
@rusko124 rusko124 mentioned this pull request Jul 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renatgalimov renatgalimov renatgalimov approved these changes

@sergey-borovkov sergey-borovkov sergey-borovkov approved these changes

@korvyashka korvyashka korvyashka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rusko124 @korvyashka @sergey-borovkov @renatgalimov