Edits: 'edge-app run' open in browser (#170)

* Edits: 'edge-app run' open in browser

* Edits after review

* Attempt to fix lint

* Revert "Edits after review"

This reverts commit 4d1b20c.

* Attempt to fix lint

* Revert "Revert "Edits after review""

This reverts commit 6fa4293.

* Fix: clippy warning

* Fix: linter warning

.github/workflows/lint.yml

@@ -9,7 +9,9 @@ jobs:
   lint:
     name: Lint code base
     runs-on: ubuntu-latest
-
+    permissions:
+      contents: 'read'
+      checks: 'write'
     steps:
       - name: Checkout code
         uses: actions/checkout@v2

src/commands/edge_app.rs

@@ -391,6 +391,13 @@ impl EdgeAppCommand {
                 address_shared.lock().unwrap().as_ref().unwrap()
             );
 
+            if let Err(e) = self.open_browser(&format!(
+                "{}/index.html",
+                address_shared.lock().unwrap().as_ref().unwrap()
+            )) {
+                eprintln!("{}", e);
+            }
+
             loop {
                 tokio::time::sleep(std::time::Duration::from_secs(3600)).await;
             }
@@ -399,6 +406,33 @@ impl EdgeAppCommand {
         Ok(())
     }
 
+    fn open_browser(&self, address: &str) -> Result<(), CommandError> {
+        let command = match std::env::consts::OS {
+            "macos" => "open",
+            "windows" => "start",
+            "linux" => "xdg-open",
+            _ => {
+                return Err(CommandError::OpenBrowserError(
+                    "Unsupported OS to open browser".to_string(),
+                ))
+            }
+        };
+
+        let output = std::process::Command::new(command)
+            .arg(address)
+            .output()
+            .expect("Failed to open browser");
+
+        if !output.status.success() {
+            return Err(CommandError::OpenBrowserError(format!(
+                "Failed to open browser: {}",
+                str::from_utf8(&output.stderr).unwrap()
+            )));
+        }
+
+        Ok(())
+    }
+
     fn maybe_delete_missing_settings(
         &self,
         delete_missing_settings: Option<bool>,

src/commands/edge_app_server.rs

@@ -80,6 +80,7 @@ pub async fn run_server(
 }
 
 #[derive(Debug)]
+#[allow(dead_code)]
 struct WarpError(#[allow(dead_code)] anyhow::Error);
 
 impl Reject for WarpError {}

src/commands/mod.rs

@@ -126,6 +126,8 @@ pub enum CommandError {
     SettingDoesNotExist(String),
     #[error("Wrong setting name: {0}.")]
     WrongSettingName(String),
+    #[error("Failed to open browser")]
+    OpenBrowserError(String),
 }
 
 pub fn get(