-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added server identity key to client bundle #69
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
triptighanghas
commented
Jun 3, 2024
•
edited
Loading
edited
- Client App | added serverIdentity key on client bundle
- Core | refactored EncryptionHeader to simplify it
- Server | added check to not process received bundles with mismatched serverIdentity key
triptighanghas
changed the title
added sender client's id to bundleDto
added server identity key to client bundle
Jun 5, 2024
JAReddy
approved these changes
Jun 10, 2024
03fernanda-palacios
pushed a commit
that referenced
this pull request
Jun 20, 2024
* added server_identity key in client bundle, refactored EncryptionHeader * added check on bundle processing on server to match serverIdentity key
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.