#77: refactor list_exists rule

src/HelpersServiceProvider.php

@@ -67,7 +67,6 @@ protected function extendValidator(): void
         });
 
         Validator::extend('list_exists', function ($attribute, $value, $parameters) {
-
             if (count($parameters) < 1) {
                 return false;
             }
@@ -76,12 +75,20 @@ protected function extendValidator(): void
             $keyField = Arr::get($parameters, 1, 'id');
 
             if (!empty(Arr::get($parameters, 2))) {
-                $value = collect($value)->pluck(Arr::get($parameters, 2));
+                $value = collect($value)
+                    ->pluck(Arr::get($parameters, 2))
+                    ->toArray();
             }
 
-            return DB::table($table)
+            $value = array_unique($value);
+
+            $existingValue = DB::table($table)
                 ->whereIn($keyField, $value)
-                ->exists();
+                ->distinct()
+                ->pluck($keyField)
+                ->toArray();
+
+            return count($existingValue) === count($value);
         });
     }
 

tests/ValidatorTest.php

@@ -67,7 +67,7 @@ public function testUniqueExceptOfAuthorizedUserFail()
 
     public function testListExists()
     {
-        $this->mockListExists(true);
+        $this->mockListExists([1, 2, 3]);
 
         $validator = Validator::make(
             ['ids' => [1, 2, 3]],
@@ -79,7 +79,7 @@ public function testListExists()
 
     public function testListExistsByArray()
     {
-        $this->mockListExists(true);
+        $this->mockListExists([1, 2, 3]);
 
         $validator = Validator::make(
             [
@@ -108,7 +108,7 @@ public function testListExistsByArray()
 
     public function testListExistsFailedValidation()
     {
-        $this->mockListExists(false);
+        $this->mockListExists([1, 2]);
 
         $validator = Validator::make(
             ['ids' => [1, 2, 3]],

tests/support/Traits/SqlMockTrait.php

@@ -432,14 +432,18 @@ protected function mockExistsUsersExceptAuthorizedByArray(
     }
 
     protected function mockListExists(
-        bool $isExist,
+        array $result,
         string $table = 'clients',
         string $keyField = 'user_id',
     ): void {
-        $this->mockSelectExists(
-            "select exists(select * from \"{$table}\" where \"{$keyField}\" in (?, ?, ?)) as \"exists\"",
-            $isExist,
-            [1, 2, 3]
+        $formattedResult = array_map(function ($id) use ($keyField) {
+            return [$keyField => $id];
+        }, $result);
+
+        $this->mockSelect(
+            query: "select distinct \"{$keyField}\" from \"{$table}\" where \"{$keyField}\" in (?, ?, ?)",
+            result: $formattedResult,
+            bindings: [1, 2, 3],
         );
     }