Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#77: refactor list_exists rule #158

Merged
merged 7 commits into from
Dec 12, 2024

Conversation

yogyrton
Copy link
Contributor

@yogyrton yogyrton commented Dec 4, 2024

#77

src/HelpersServiceProvider.php Outdated Show resolved Hide resolved
src/HelpersServiceProvider.php Outdated Show resolved Hide resolved
src/HelpersServiceProvider.php Outdated Show resolved Hide resolved
@aizlee aizlee assigned yogyrton and unassigned aizlee Dec 5, 2024
@yogyrton yogyrton assigned aizlee and unassigned yogyrton Dec 5, 2024
@aizlee aizlee assigned yogyrton and unassigned aizlee Dec 6, 2024
@yogyrton yogyrton assigned aizlee and unassigned yogyrton Dec 6, 2024
@aizlee
Copy link

aizlee commented Dec 9, 2024

@yogyrton We need to check if we provide duplicate values the list_exists method works correctly. Please add a test for this case.

@aizlee aizlee assigned yogyrton and unassigned aizlee Dec 9, 2024
@yogyrton yogyrton assigned aizlee and unassigned yogyrton Dec 9, 2024
@aizlee aizlee assigned DenTray and unassigned aizlee Dec 10, 2024
@aizlee aizlee requested a review from DenTray December 10, 2024 10:47
tests/support/Traits/SqlMockTrait.php Show resolved Hide resolved
tests/support/Traits/SqlMockTrait.php Outdated Show resolved Hide resolved
tests/ValidatorTest.php Outdated Show resolved Hide resolved
tests/ValidatorTest.php Outdated Show resolved Hide resolved
@DenTray
Copy link
Collaborator

DenTray commented Dec 12, 2024

@yogyrton please check failed tests, it fails after #158 (comment)

@DenTray DenTray removed their assignment Dec 12, 2024
@yogyrton yogyrton assigned DenTray and unassigned yogyrton Dec 12, 2024
@DenTray DenTray merged commit f9478a5 into master Dec 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants