e2e: Prepare for adding test.Env #1769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
We want to make the config accessing from the test context, and possibly move it around. Having related stuff in the same file makes it easier to work with the code. Signed-off-by: Nir Soffer <[email protected]>
- Make util.RamenOpsNamespace private constant of the discoveredapp deployer - Make util.ArgocdNamespace private constant of the applicatioset deployer - Make util.RamenNamespace private constant of validation file Signed-off-by: Nir Soffer <[email protected]>
The only constants left are timeouts, so we can have a more meaningful name. Signed-off-by: Nir Soffer <[email protected]>
We need to create a channel before running tests using subscriptions or applicationset, and delete it at the end. This code seems like part of the deployers pacakge. To move it we need to uncouple it from the util package. The first step is move the related code to a new file. Signed-off-by: Nir Soffer <[email protected]>
We don't have ordering dependencies in Go so we can keep the public names at the start of the file for easier navigation. Signed-off-by: Nir Soffer <[email protected]>
Split out the drpolicy function to drpolicy.go and rename the file to namespace.go. Now we can understand better the structure of the util package. Signed-off-by: Nir Soffer <[email protected]>
It is used only in CreateNamespaceAndAnnotation, lets keep it private to avoid future dependencies. Part-of: RamenDR#1715 Signed-off-by: Nir Soffer <[email protected]>
ELENAGER
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up the e2e/util package, preparing for adding test.Env.
Part-of #1715