Eliminate channel name configuration #1779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirs
force-pushed
the
e2e-channel-name
branch
3 times, most recently
from
0a62530 to
151a25f
Compare
nirs
force-pushed
the
e2e-channel-name
branch
from
151a25f to
bc77d4a
Compare
nirs
commented
Feb 3, 2025
nirs
force-pushed
the
e2e-channel-name
branch
from
bc77d4a to
d7b49e2
Compare
nirs
force-pushed
the
e2e-channel-name
branch
from
d7b49e2 to
07e0f9d
Compare
parikshithb
approved these changes
Feb 5, 2025
rakeshgm
approved these changes
Feb 5, 2025
Instead of configuring channel name, generate the name from the repo
url. This makes the configuration simpler and make it easy to test
multiple channels.
Example channel name:
gitURL: https://github.com/RamenDR/ocm-ramen-samples.git
channel: https-github-com-ramendr-ocm-ramen-samples-git
Signed-off-by: Nir Soffer <[email protected]>
Use e2e- prefix so the namespace sorts with other namespaces created by e2e, and change ramen-samples to gitops to reflect better the purpose of the namespace. Signed-off-by: Nir Soffer <[email protected]>
- Unify state change messages (Create channel, Deleted channel) - Log also channel namespace - Log debug logs (already exists, not found) in DEBUG level Signed-off-by: Nir Soffer <[email protected]>
nirs
force-pushed
the
e2e-channel-name
branch
from
07e0f9d to
ac3557b
Compare
|
This version rebase on main and resolved trivial conflict. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate the channel name from the git URL instead of complicating the config file and improve channel namespace name.