-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixup setup.py + add pre-commit #142
base: 2.0
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
# See https://pre-commit.com for more information | ||
# See https://pre-commit.com/hooks.html for more hooks | ||
|
||
repos: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. TODO: Should we add |
||
- repo: https://github.com/pre-commit/pre-commit-hooks | ||
rev: v3.2.0 | ||
hooks: | ||
- id: trailing-whitespace | ||
- id: end-of-file-fixer | ||
- id: check-yaml | ||
- id: check-added-large-files | ||
|
||
# TODO: Add ruff + ruff format for nice linting and consistency | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Add pre-commit to make it easier to contribute to the repo -- TODO: standardize how to install this? Should we add a Makefile? |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,4 +3,3 @@ global-include *.pxd | |
global-include *.h | ||
global-include *.py | ||
recursive-include pufferlib/resources * | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,3 +19,7 @@ All of our documentation is hosted at [puffer.ai](https://puffer.ai "PufferLib D | |
<img alt="Star History Chart" src="https://api.star-history.com/svg?repos=pufferai/pufferlib&type=Date" /> | ||
</picture> | ||
</a> | ||
|
||
## Contributions | ||
|
||
We're always looking for new contributors! When first starting out, don't forget to run `pre-commit install` before committing. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. README still could benefit from more details and context, it's bumpy coming in as a new user, but this is a nice start |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -30,5 +30,3 @@ def compute_gae(cnp.ndarray dones, cnp.ndarray values, | |
c_advantages[t_cur] = lastgaelam | ||
|
||
return advantages | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
[base] | ||
package = atari | ||
env_name = enduro | ||
env_name = enduro | ||
|
||
[train] | ||
total_timesteps = 16_657_125 | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -42,5 +42,3 @@ max = 524288 | |
distribution = uniform | ||
min = 2048 | ||
max = 32768 | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -58,4 +58,3 @@ max = 0.0 | |
distribution = uniform | ||
min = 1_000_000_000 | ||
max = 10_000_000_000 | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
[base] | ||
package = ocean | ||
env_name = puffer_pong | ||
env_name = puffer_pong | ||
policy_name = Policy | ||
rnn_name = Recurrent | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -26,6 +26,3 @@ gae_lambda = 0.8297991396183212 | |
vf_coef = 0.3974834958825928 | ||
clip_coef = 0.1 | ||
vf_clip_coef = 0.1 | ||
|
||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,4 +10,4 @@ | |
try: | ||
from .policy import Recurrent | ||
except: | ||
Recurrent = None | ||
Recurrent = None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These files are all generated when you run
pip install --editable .
-- seems like they should be in the .gitignore