Fixup setup.py + add pre-commit #142
Conversation
| @@ -139,3 +139,10 @@ checkpoints/ | |||
| experiments/ | |||
| wandb/ | |||
| raylib/ | |||
|
|
|||
| c_gae.c | |||
There was a problem hiding this comment.
These files are all generated when you run pip install --editable . -- seems like they should be in the .gitignore
| - id: check-yaml | ||
| - id: check-added-large-files | ||
|
|
||
| # TODO: Add ruff + ruff format for nice linting and consistency |
There was a problem hiding this comment.
Add pre-commit to make it easier to contribute to the repo -- TODO: standardize how to install this? Should we add a Makefile?
|
|
||
| ## Contributions | ||
|
|
||
| We're always looking for new contributors! When first starting out, don't forget to run `pre-commit install` before committing. |
There was a problem hiding this comment.
README still could benefit from more details and context, it's bumpy coming in as a new user, but this is a nice start
| @@ -1,3 +1,9 @@ | |||
| [build-system] | |||
| requires = ["setuptools", "wheel", "Cython", "numpy"] | |||
| build-backend = "setuptools.build_meta" | |||
|
|
|||
| [tool.ruff] | |||
| line-length = 130 | |||
There was a problem hiding this comment.
Start standardizing the formatting a bit
| author_email="[email protected]", | ||
| url="https://github.com/PufferAI/PufferLib", | ||
| keywords=["Puffer", "AI", "RL", "Reinforcement Learning"], | ||
| include_dirs=[numpy.get_include(), RAYLIB_INCLUDE_DIR], |
There was a problem hiding this comment.
This was previously hardcoded, and was a bug causing breakage on MacOS.
| # The extension “.so” is typically in pufferlib/ocean/..., | ||
| # and “raylib/lib” is (maybe) two directories up from ocean/<env>. | ||
| # So @loader_path/../../raylib/lib is common. | ||
| rpath_arg = '-Wl,-rpath,@loader_path/../../raylib/lib' |
There was a problem hiding this comment.
I ran into a variety of linkage issues here, this was the best I could come up with. Happy to hear any better ideas or solutions to make this cleaner across platforms.
| # See https://pre-commit.com for more information | ||
| # See https://pre-commit.com/hooks.html for more hooks | ||
|
|
||
| repos: |
There was a problem hiding this comment.
TODO: Should we add pre-commit to requirements.txt or something? Not sure how this repo handles dev dependencies, a bit confusing...
No description provided.