-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preprocessing Pipeline #412
Conversation
This reverts commit 5ae3283.
Amazing! It looks good to me. Now we also use tbb for deskewing + only deskew the points that are not clipped :) It's OK to keep the voxel downsampling for now because we also use it in the VoxelHashMap, which is not part of Preprocessing. |
The base branch was changed.
Successive commits represents the fact that me and @benemer realize that the numbers were differing slightly from |
Motivation
I finally wanted to tackle #295, as the preprocessing has been an asymmetry in the design for a while, and I would like to have an emotional closure with it. As a side effect, this also allows control of the number of threads for deskewing, as now all preprocessing is performed in a single module (similar to the attempt already made in #400).
This PR
Introduce the
Preprocessor
module, which is in charge of clipping the scan to themin
/max
range and performing the motion compensation. For now, I kept the voxel downsampling outside the preprocessing pipeline, although we could merge it in this module if we like the idea.Results
Of course, I obtained the same numbers in terms of runtime and "accuracy" for the few sequences I tested.