Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor snapshot creation and check trace data against snapshot #24

Merged
merged 6 commits into from
Dec 16, 2024

Conversation

nick-gorman
Copy link
Member

@nick-gorman nick-gorman commented Nov 28, 2024

  • snapshot definition is moved to the translator
  • conversion to 'ns' datetime units for traces is moved to the translator
  • functionality added to check traces against snapshot before they are saved by the translator
  • Also changes config structure so all config inputs related to temporality sit under the 'temporal' key

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 79.66102% with 12 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/ispypsa/config/validators.py 53.84% 3 Missing and 3 partials ⚠️
src/ispypsa/translator/buses.py 33.33% 2 Missing ⚠️
src/ispypsa/translator/generators.py 33.33% 2 Missing ⚠️
src/ispypsa/translator/time_series_checker.py 87.50% 0 Missing and 2 partials ⚠️
Files with missing lines Coverage Δ
src/ispypsa/model/buses.py 35.71% <ø> (+2.38%) ⬆️
src/ispypsa/model/generators.py 26.08% <ø> (+1.08%) ⬆️
src/ispypsa/model/initialise.py 100.00% <100.00%> (+68.75%) ⬆️
src/ispypsa/translator/snapshot.py 100.00% <100.00%> (ø)
src/ispypsa/translator/buses.py 20.00% <33.33%> (+1.08%) ⬆️
src/ispypsa/translator/generators.py 23.52% <33.33%> (+0.94%) ⬆️
src/ispypsa/translator/time_series_checker.py 87.50% <87.50%> (ø)
src/ispypsa/config/validators.py 81.13% <53.84%> (ø)

... and 5 files with indirect coverage changes

@nick-gorman nick-gorman requested a review from prakaa December 9, 2024 03:04
@nick-gorman nick-gorman mentioned this pull request Dec 10, 2024
Copy link
Member

@prakaa prakaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good @nick-gorman, minor renaming suggestions only

src/ispypsa/translator/snapshot.py Outdated Show resolved Hide resolved
src/ispypsa/translator/snapshot.py Outdated Show resolved Hide resolved
@nick-gorman nick-gorman merged commit a28448d into main Dec 16, 2024
14 checks passed
@nick-gorman nick-gorman deleted the snapshot-refactor branch December 16, 2024 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants