Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Representative weeks #30

Merged
merged 11 commits into from
Dec 16, 2024
Merged

Representative weeks #30

merged 11 commits into from
Dec 16, 2024

Conversation

nick-gorman
Copy link
Member

Adds option to filter model snapshot by a list of weeks for each year.

Branched off #24, which should be merged into the main first.

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 93.47826% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/ispypsa/translator/buses.py 50.00% 1 Missing ⚠️
src/ispypsa/translator/generators.py 50.00% 1 Missing ⚠️
src/ispypsa/translator/temporal_filters.py 96.42% 0 Missing and 1 partial ⚠️
Files with missing lines Coverage Δ
src/ispypsa/config/validators.py 82.14% <100.00%> (+1.01%) ⬆️
src/ispypsa/translator/helpers.py 100.00% <100.00%> (ø)
src/ispypsa/translator/snapshot.py 100.00% <100.00%> (ø)
src/ispypsa/translator/buses.py 21.42% <50.00%> (+1.42%) ⬆️
src/ispypsa/translator/generators.py 25.00% <50.00%> (+1.47%) ⬆️
src/ispypsa/translator/temporal_filters.py 96.42% <96.42%> (ø)

@nick-gorman nick-gorman requested a review from prakaa December 10, 2024 05:59
Copy link
Member

@prakaa prakaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments around configs structuring, representative weeks indexing and naming of funcs/args

src/ispypsa/config/validators.py Outdated Show resolved Hide resolved
src/ispypsa/translator/temporal_filters.py Outdated Show resolved Hide resolved
src/ispypsa/translator/snapshot.py Outdated Show resolved Hide resolved
src/ispypsa/translator/temporal_filters.py Outdated Show resolved Hide resolved
src/ispypsa/translator/temporal_filters.py Show resolved Hide resolved
src/ispypsa/translator/temporal_filters.py Outdated Show resolved Hide resolved
@nick-gorman nick-gorman merged commit bb3a895 into main Dec 16, 2024
15 checks passed
@nick-gorman nick-gorman deleted the representative-weeks branch December 16, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants