Fix readme dockerfile and JS formatting

.djlintrc

@@ -1,3 +1,3 @@
 {
     "ignore": "H006"
-}
+}

.gitignore

@@ -6,7 +6,7 @@
 # Folders
 _obj
 _test
-.idea/*
+node_modules
 
 # Architecture specific extensions/prefixes
 *.[568vq]
@@ -31,3 +31,4 @@ eq-questionnaire-launcher
 
 # Dev config
 .vscode/
+.idea/*

Dockerfile

@@ -1,5 +1,5 @@
 # Start from golang base image
-FROM golang:1.21 as builder
+FROM golang:1.21 AS builder
 
 WORKDIR /go/src/github.com/ONSdigital/eq-questionnaire-launcher
 

README.md

@@ -2,7 +2,7 @@
 
 This project was copied from https://github.com/ONSdigital/go-launch-a-survey and should be used for v3 of runner.
 
-### Building and Running
+## Building and Running
 Install Go and ensure that your `GOPATH` env variable is set (usually it's `~/go`).
 
 ```
@@ -15,7 +15,7 @@ go run launch.go (Does both the build and run cmd above)
 
 Open http://localhost:8000/
 
-### Docker
+## Docker
 The dockerfile is a multistage dockerfile which can be built using:
 
 ```
@@ -42,7 +42,7 @@ You can also run a Survey Register for launcher to load Schemas from
 docker run -it -p 8080:8080 onsdigital/eq-survey-register:simple-rest-api
 ```
 
-### Run Quick-Launch
+## Run Quick-Launch
 If the schema specifies a `schema_name` field, that will be used as the schema_name claim. If not, the filename from the URL (before `.`) will be used.
 
 Run Questionnaire Launcher
@@ -60,7 +60,7 @@ Documentation on the `v2` structure can be found [here](https://github.com/ONSdi
 e.g."http://localhost:8000/quick-launch?schema_url=http://localhost:7777/1_0001.json&version=v1"
 ```
 
-### Commands for Formatting & Linting
+## Commands for Formatting & Linting
 Ensure you are using the correct version of node using:
 ``` shell
 nvm install
@@ -75,8 +75,8 @@ Firstly, ensure you have Python & Poetry installed and then install djLint for f
 poetry install
 ```
 
- **Note**: Before being able to run `lint-go`, 
-you will need to install the external tool `golangci-lint`. The command to install the tool is 
+ **Note**: Before being able to run `lint-go`,
+you will need to install the external tool `golangci-lint`. The command to install the tool is
 `brew install golangci-lint` and to upgrade it use `brew upgrade golangci-lint`. Visit
 https://golangci-lint.run/welcome/install/#local-installation to see additional ways to install the tool.
 
@@ -92,18 +92,18 @@ https://golangci-lint.run/welcome/install/#local-installation to see additional
 | `make lint`             | Lints all files listed above                            |
 
 
-### Design System
-To update the design system version, you need to update the version within the CDN link, they are present in both template files ([layout](templates/layout.html:11) and [launch](templates/launch.html:381)) 
+## Design System
+To update the design system version, you need to update the version within the CDN link, they are present in both template files ([layout](templates/layout.html:11) and [launch](templates/launch.html:381))
 
-### Notes
+## Notes
 * There are no unit tests yet
 * JWT spec based on http://ons-schema-definitions.readthedocs.io/en/latest/jwt_profile.html
 
-### Settings
+## Settings
 
 | Environment Variable           | Meaning                                                             | Default                                                                |
 |--------------------------------|---------------------------------------------------------------------|------------------------------------------------------------------------|
-| GO_LAUNCH_A_SURVEY_LISTEN_HOST | Host address  to listen on                                          | 0.0.0.0                                                                |
+| GO_LAUNCH_A_SURVEY_LISTEN_HOST | Host address to listen on                                           | 0.0.0.0                                                                |
 | GO_LAUNCH_A_SURVEY_LISTEN_PORT | Host port to listen on                                              | 8000                                                                   |
 | SURVEY_RUNNER_URL              | URL of Questionnaire Runner to re-direct to when launching a survey | http://localhost:5000                                                  |
 | SURVEY_REGISTER_URL            | URL of eq-survey-register to load schema list from                  | http://localhost:8080                                                  |

pyproject.toml

@@ -13,4 +13,4 @@ djlint = "^1.34.1"
 
 [build-system]
 requires = ["poetry-core"]
-build-backend = "poetry.core.masonry.api"
+build-backend = "poetry.core.masonry.api"

static/javascript/launch.js

@@ -81,7 +81,7 @@
             ].join("");
           }
           for (var t = [], i = 0; i < 256; ++i)
-            t[i] = (i + 256).toString(16).substr(1);
+            t[i] = (i + 256).toString(16).substring(1);
           n.exports = o;
         },
         {},
@@ -90,8 +90,7 @@
         function (e, n, r) {
           var o =
             ("undefined" != typeof crypto &&
-              crypto.getRandomValues &&
-              crypto.getRandomValues.bind(crypto)) ||
+              crypto.getRandomValues?.bind(crypto)) ||
             ("undefined" != typeof msCrypto &&
               "function" == typeof window.msCrypto.getRandomValues &&
               msCrypto.getRandomValues.bind(msCrypto));
@@ -213,17 +212,17 @@ function showMetadataAccordion(type, show) {
   }
 }
 
-function enableButtons(button) {
-  for (let i = 0; i < button.length; i++) {
-    button[i].classList.remove("ons-btn--disabled");
-    button[i].disabled = false;
+function enableButtons(buttons) {
+  for (const button of buttons) {
+    button.classList.remove("ons-btn--disabled");
+    button.disabled = false;
   }
 }
 
-function disableButtons(button) {
-  for (let i = 0; i < button.length; i++) {
-    button[i].classList.add("ons-btn--disabled");
-    button[i].disabled = true;
+function disableButtons(buttons) {
+  for (const button of buttons) {
+    button.classList.add("ons-btn--disabled");
+    button.disabled = true;
   }
 }
 
@@ -250,9 +249,9 @@ function includeSurveyMetadataFields(schema_name, survey_type) {
 
   document.querySelector("#survey_metadata_fields").innerHTML =
     `<div class="ons-field ons-field--inline">
-                    <label class="ons-label" for="form_type">form_type</label>
-                    <input id="form_type" name="form_type" type="text" value="${formTypeValue}" class="ons-input ons-input--text ons-input-type__input">
-                </div>`;
+      <label class="ons-label" for="form_type">form_type</label>
+      <input id="form_type" name="form_type" type="text" value="${formTypeValue}" class="ons-input ons-input--text ons-input-type__input">
+    </div>`;
   setTabIndex("survey_type_metadata_detail", 0);
   showMetadataAccordion("sds", true);
 }
@@ -453,7 +452,6 @@ function loadSchemaMetadata(schemaName, schemaUrl, cirInstrumentId) {
   getDataAsync(survey_data_url)
     .then((schema_response) => {
       document.querySelector("#survey_metadata").innerHTML = "";
-      document.querySelector("#survey_metadata").innerHTML = "";
 
       // We always need survey_id from top-level schema metadata for SDS retrieval
       schemaSurveyId = schema_response.survey_id;