Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix readme dockerfile and JS formatting #89

Merged
merged 10 commits into from
Aug 12, 2024
Merged

Fix readme dockerfile and JS formatting #89

merged 10 commits into from
Aug 12, 2024

Conversation

rmccar
Copy link
Contributor

@rmccar rmccar commented Aug 12, 2024 •
edited
Loading

What is the context of this PR?

This is a cleanup PR to tidy up a few different things in the repo. This includes:

  • Updating the .gitignore file to ignore node modules
  • Update some dockerfile syntax
  • Update the readme formatting
  • Update some js formatting and update some of the syntax to use more modern alternatives

How to review

  • Test launcher still works as expected and that schemas can still be launched
  • Changes make sense

@rmccar rmccar changed the title Fix readme docker file and js formatting Fix readme dockerfile and js formatting Aug 12, 2024
@rmccar rmccar changed the title Fix readme dockerfile and js formatting Fix readme dockerfile and JS formatting Aug 12, 2024
@rmccar rmccar merged commit 05dba4e into main Aug 12, 2024
3 checks passed
@rmccar rmccar deleted the fix-linting-issues-in-launcher branch August 12, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VirajP1002 VirajP1002 VirajP1002 approved these changes

@liamtoozer liamtoozer liamtoozer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rmccar @liamtoozer @VirajP1002