Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][ADD] sale_rental #46

Open
wants to merge 42 commits into
base: 16.0
Choose a base branch
from
Open

[16.0][ADD] sale_rental #46

wants to merge 42 commits into from

Conversation

coffeinisfun
Copy link

Add the module sale_rental to vertical-rental. This module was in sale-workflow in previous versions, but it was suggested that it is moved to vertical-rental starting with version 16.0
see this PR: OCA/sale-workflow#2325
the actual migration work was done by @Murtaza-OSI

Cherrry-picked the relevant commits from the original mig-branch to preserve history

Alexis de Lattre and others added 30 commits March 6, 2024 10:34
Port sale_start_end_dates and sale_rental (#353)
b413847
@dvdhinesh
sale_start_end_dates and sale_rental
ce147a4
@alexis-via
Product qty on rental pickings
7f35cb5 
Replace openerp by odoo in import declarations
@alexis-via
Auto configure sale_rental module via post_install.py script
175448d
@alexis-via
sale_rental: fix warning @constrains parameter 'must_have_dates' is n…
72b1205 
…ot writeable
@rousseldenis
pylint
8ddd7ec
sale_rental: Migration to 11.0
e5fb38d
@alexis-via
[MIG] sale_start_end_dates and sale_rental to v12
9ebdd03 
Convert readme to new subdir format
@alexis-via
sale_rental: Improve the code of object sale.rental
e7a8bb7
@gurneyalex
[IMP] enhancements suggested in code reviews
a201145 
the creation of the stock location for rental respects the translations
@sadamo
[FIX] Archive rental routes rather than delete
4fbbd01
@oca-travis
[UPD] Update sale_rental.pot
0fc7324
@OCA-git-bot
[UPD] README.rst
f845663
@marcelsavegnago
Added translation using Weblate (Portuguese (Brazil))
ab9ed96
@marcelsavegnago
Translated using Weblate (Portuguese (Brazil))
4ceca70 
Currently translated at 85.4% (88 of 103 strings)

Translation: sale-workflow-12.0/sale-workflow-12.0-sale_rental
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_rental/pt_BR/
@oca-transbot
Update translation files
e0c999c 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-12.0/sale-workflow-12.0-sale_rental
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_rental/
@oca-transbot
Update translation files
fbe5da8 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-12.0/sale-workflow-12.0-sale_rental
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_rental/
@pedrocs-exo
Translated using Weblate (Portuguese)
d4e49b0 
Currently translated at 9.7% (10 of 103 strings)

Translation: sale-workflow-12.0/sale-workflow-12.0-sale_rental
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_rental/pt/
@yweng8111
[IMP] sale_rental: extract function _run_rental_procurement
21b063b
@oca-travis
[UPD] Update sale_rental.pot
36e1487
@OCA-git-bot
sale_rental 12.0.1.1.0
65cca7b
@oca-transbot
Update translation files
c55e04a 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-12.0/sale-workflow-12.0-sale_rental
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_rental/
@oca-travis
[UPD] Update sale_rental.pot
05e5e3b
@oca-transbot
Update translation files
4236c94 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-12.0/sale-workflow-12.0-sale_rental
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_rental/
@alexis-via
[MIG] sale_rental from v12 to v14
4f7173f 
No more need to add users to the packaging group
View of rental group is now possible on product.template form view
@alexis-via
sale_rental: black, isort, etc.
29fee5a
@oca-travis
[UPD] Update sale_rental.pot
314c3d5
@OCA-git-bot
[UPD] README.rst
6343264
@kirca
[MIG] sale_rental: Migration to 15.0
716dd34 
Standard migration + add some tests
@kirca
[IMP] : black, isort, prettier, pylint
bad0adf
oca-ci and others added 9 commits March 6, 2024 10:54
[UPD] Update sale_rental.pot
104aa9d
@OCA-git-bot
[UPD] README.rst
2077d55
@OCA-git-bot
sale_rental 15.0.1.0.1
f7f67df
@OCA-git-bot
[UPD] README.rst
55c39f2
@OCA-git-bot
[UPD] README.rst
889d6fd
@gregory-moka
Translated using Weblate (French (France))
c2c3372 
Currently translated at 40.7% (42 of 103 strings)

Translation: sale-workflow-15.0/sale-workflow-15.0-sale_rental
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_rental/fr_FR/
@gregory-moka
Translated using Weblate (French (France))
bbf82aa 
Currently translated at 63.1% (65 of 103 strings)

Translation: sale-workflow-15.0/sale-workflow-15.0-sale_rental
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_rental/fr_FR/
@gregory-moka
Translated using Weblate (French)
8faaa16 
Currently translated at 49.5% (51 of 103 strings)

Translation: sale-workflow-15.0/sale-workflow-15.0-sale_rental
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_rental/fr/
@Murtaza-OSI
[16.0][MIG] sale_rental
a209503
@coffeinisfun coffeinisfun mentioned this pull request Mar 6, 2024
Closed
@yelizariev
Copy link
Member

Hello!

Please check test errors

2024-03-07 12:20:38,782 242 INFO odoo odoo.addons.sale_rental.tests.test_sale_rental: ====================================================================== 
2024-03-07 12:20:38,782 242 ERROR odoo odoo.addons.sale_rental.tests.test_sale_rental: FAIL: TestSaleRental.test_main
Traceback (most recent call last):
  File "/__w/vertical-rental/vertical-rental/sale_rental/tests/test_sale_rental.py", line 36, in test_main
    self.assertEqual(len(so.picking_ids), 2)
AssertionError: 0 != 2

@coffeinisfun
Copy link
Author

Hello!

Please check test errors

2024-03-07 12:20:38,782 242 INFO odoo odoo.addons.sale_rental.tests.test_sale_rental: ====================================================================== 
2024-03-07 12:20:38,782 242 ERROR odoo odoo.addons.sale_rental.tests.test_sale_rental: FAIL: TestSaleRental.test_main
Traceback (most recent call last):
  File "/__w/vertical-rental/vertical-rental/sale_rental/tests/test_sale_rental.py", line 36, in test_main
    self.assertEqual(len(so.picking_ids), 2)
AssertionError: 0 != 2

Yes, I'm aware. I try to fix it, though I did not write these tests myself, so it might take a while

@adasatorres adasatorres mentioned this pull request Sep 16, 2024
Open
@marylla
Copy link

marylla commented Sep 17, 2024

@alexis-via Do you mind review this one?

@metaminux metaminux mentioned this pull request Sep 27, 2024
Open
@Christian-RB Christian-RB mentioned this pull request Nov 27, 2024
Open
@edescalona edescalona mentioned this pull request Nov 27, 2024
Open
edescalona
edescalona approved these changes Nov 29, 2024
View reviewed changes
Copy link

@edescalona edescalona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edescalona edescalona mentioned this pull request Jan 21, 2025
Open
@rousseldenis rousseldenis added this to the 16.0 milestone Jan 21, 2025
Pablocce
Pablocce approved these changes Feb 3, 2025
View reviewed changes
Copy link

@Pablocce Pablocce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adasatorres adasatorres adasatorres approved these changes

@Pablocce Pablocce Pablocce approved these changes

@edescalona edescalona edescalona approved these changes

Assignees

@alexis-via alexis-via

Labels
approved needs review
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.