-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][MIG] rental_base #48
base: 16.0
Are you sure you want to change the base?
Conversation
* selectively add some files from the v12 branch * initial add of several rental modules * [UPD] Update rental_base.pot * Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: vertical-rental-12.0/vertical-rental-12.0-rental_base Translate-URL: https://translation.odoo-community.org/projects/vertical-rental-12-0/vertical-rental-12-0-rental_base/ * [IMP] rental_base: black, isort, prettier * [MIG] rental_base: Migration to 14.0 Co-authored-by: Maria Sparenberg <[email protected]> Co-authored-by: oca-travis <[email protected]> Co-authored-by: OCA Transbot <[email protected]> Co-authored-by: cpatel <[email protected]>
Currently translated at 96.0% (97 of 101 strings) Translation: vertical-rental-14.0/vertical-rental-14.0-rental_base Translate-URL: https://translation.odoo-community.org/projects/vertical-rental-14-0/vertical-rental-14-0-rental_base/fr/
…cks dangerous-view-replace-wo-priority
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: vertical-rental-14.0/vertical-rental-14.0-rental_base Translate-URL: https://translation.odoo-community.org/projects/vertical-rental-14-0/vertical-rental-14-0-rental_base/
…interval, rental_product_pack: black, isort, prettier
272657c
to
3e8df94
Compare
3e8df94
to
e714c5a
Compare
e714c5a
to
9a6827f
Compare
/ocabot migration rental_base |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
rental_base/views/sale_view.xml
Outdated
|
||
<xpath expr="//group[@id='further_rental_info']" position="inside"> | ||
<xpath | ||
expr="//group//field[@name='analytic_distribution']" | ||
position="inside" | ||
> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, i detected an error with the migration, with this change you are not allowed to navegate throw the sale.order rental view due if the user has this access rule: Analytic Accounting.
To replicate it is as simple as checking that rule, just by swaping the expresion should works fine:
<xpath expr="//group//field[@name='analytic_distribution']/.." position="inside">
Hi, I used the sale_rental from the following PR #46 for migrate this addon.