Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] rental_base #48

Open
wants to merge 21 commits into
base: 16.0
Choose a base branch
from

Conversation

adasatorres
Copy link

Hi, I used the sale_rental from the following PR #46 for migrate this addon.

chandni299 and others added 14 commits September 16, 2024 09:29
* selectively add some files from the v12 branch

* initial add of several rental modules

* [UPD] Update rental_base.pot

* Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: vertical-rental-12.0/vertical-rental-12.0-rental_base
Translate-URL: https://translation.odoo-community.org/projects/vertical-rental-12-0/vertical-rental-12-0-rental_base/

* [IMP] rental_base: black, isort, prettier

* [MIG] rental_base: Migration to 14.0

Co-authored-by: Maria Sparenberg <[email protected]>
Co-authored-by: oca-travis <[email protected]>
Co-authored-by: OCA Transbot <[email protected]>
Co-authored-by: cpatel <[email protected]>
Currently translated at 96.0% (97 of 101 strings)

Translation: vertical-rental-14.0/vertical-rental-14.0-rental_base
Translate-URL: https://translation.odoo-community.org/projects/vertical-rental-14-0/vertical-rental-14-0-rental_base/fr/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: vertical-rental-14.0/vertical-rental-14.0-rental_base
Translate-URL: https://translation.odoo-community.org/projects/vertical-rental-14-0/vertical-rental-14-0-rental_base/
…interval, rental_product_pack: black, isort, prettier
@adasatorres adasatorres force-pushed the 16.0-mig-rental_base branch 2 times, most recently from 272657c to 3e8df94 Compare September 17, 2024 13:13
@yvaucher
Copy link
Member

/ocabot migration rental_base

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Sep 30, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Sep 30, 2024
2 tasks
Copy link

@edescalona edescalona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@Pablocce Pablocce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines 248 to 232

<xpath expr="//group[@id='further_rental_info']" position="inside">
<xpath
expr="//group//field[@name='analytic_distribution']"
position="inside"
>
Copy link

@Pablocce Pablocce Feb 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, i detected an error with the migration, with this change you are not allowed to navegate throw the sale.order rental view due if the user has this access rule: Analytic Accounting.

To replicate it is as simple as checking that rule, just by swaping the expresion should works fine:
<xpath expr="//group//field[@name='analytic_distribution']/.." position="inside">

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.