Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0] [MIG] sale_order_line_menu: Migration to 18.0 #3470

Open
wants to merge 17 commits into
base: 18.0
Choose a base branch
from

Conversation

Borruso
Copy link
Contributor

@Borruso Borruso commented Dec 7, 2024

Migration from 17.0 to 18.0

Issue: #3344

Freni-OSI and others added 16 commits December 7, 2024 15:31
… (Belgium))

Translated using Weblate (French (France))

Currently translated at 100.0% (1 of 1 strings)

Translation: sale-workflow-14.0/sale-workflow-14.0-sale_order_line_menu
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_order_line_menu/fr_FR/

Added translation using Weblate (Spanish)

Translated using Weblate (Spanish)

Currently translated at 100.0% (1 of 1 strings)

Translation: sale-workflow-14.0/sale-workflow-14.0-sale_order_line_menu
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_order_line_menu/es/

Added translation using Weblate (French (Belgium))

Added translation using Weblate (French)

Translated using Weblate (French)

Currently translated at 100.0% (1 of 1 strings)

Translation: sale-workflow-14.0/sale-workflow-14.0-sale_order_line_menu
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_order_line_menu/fr/
New views and fields added to the sale_order_line_menu

MT-2028 @moduon @rafaelbn @dreispt @Shide @fcvalgar please review
Currently translated at 100.0% (19 of 19 strings)

Translation: sale-workflow-16.0/sale-workflow-16.0-sale_order_line_menu
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_order_line_menu/es/
@Borruso Borruso force-pushed the 18.0-mig-sale_order_line_menu branch 2 times, most recently from 51a7f4c to 414a138 Compare December 7, 2024 15:20
@Naraka
Copy link

Naraka commented Dec 9, 2024

If you try to create a new order line within the form of an existing order line, it throws an error.

Captura desde 2024-12-09 17-05-02

@rousseldenis
Copy link
Contributor

/ocabot migration sale_order_line_menu

Copy link

@sheragar sheragar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Funtional Review 👍

@Borruso Borruso force-pushed the 18.0-mig-sale_order_line_menu branch 2 times, most recently from 77878fb to 96bf699 Compare December 12, 2024 14:32
@Borruso
Copy link
Contributor Author

Borruso commented Dec 12, 2024

If you try to create a new order line within the form of an existing order line, it throws an error.

Captura desde 2024-12-09 17-05-02

Can you check again?

Copy link

@Naraka Naraka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested in runboat

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Copy link
Contributor

@Shide Shide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@Borruso Borruso force-pushed the 18.0-mig-sale_order_line_menu branch from 96bf699 to 7f8fa7a Compare January 10, 2025 09:35
@Borruso Borruso force-pushed the 18.0-mig-sale_order_line_menu branch 3 times, most recently from c8a0606 to fdbf560 Compare January 13, 2025 08:54
@Borruso Borruso force-pushed the 18.0-mig-sale_order_line_menu branch from fdbf560 to c7bde69 Compare January 13, 2025 09:01
Copy link
Contributor

@PieterPaulussen PieterPaulussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes regarding my feedback. There are indeed other issues that need to be addressed in a different PR. But this will suffice for now. THanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.