Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][IMP] github_connector_odoo: Remove uninstallable #130

Open
wants to merge 1 commit into
base: 15.0
Choose a base branch
from
Open

[15.0][IMP] github_connector_odoo: Remove uninstallable #130

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion github_connector_odoo/models/github_repository_branch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,11 +234,22 @@
)
# Create module version, if the module is installable
# in the serie
if module_info.get("installable", False):
if module_info.get("installable", True):
module_info["technical_name"] = module_name
module_version_obj.create_or_update_from_manifest(
module_info, self, full_module_path
)
else:
# Otherwise remove module version if exist
module_version = self.search(

Check warning on line 244 in github_connector_odoo/models/github_repository_branch.py

View check run for this annotation

Codecov / codecov/patch

github_connector_odoo/models/github_repository_branch.py#L244 

Added line #L244 was not covered by tests
[
("technical_name", "=", module_name),
("repository_branch_id", "=", self.id),
]
)
if module_version:
module_version._process_clean_module_version()

Check warning on line 251 in github_connector_odoo/models/github_repository_branch.py

View check run for this annotation

Codecov / codecov/patch

github_connector_odoo/models/github_repository_branch.py#L251 

Added line #L251 was not covered by tests

except Exception as e:
_logger.error(
"Cannot process module with name %s, error " "is: %s", module_name, e
Expand Down
Loading