Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][IMP] github_connector_odoo: Remove uninstallable #130

Open
wants to merge 1 commit into
base: 15.0
Choose a base branch
from

Conversation

hhgabelgaard
Copy link

The default for installable is True

@pedrobaeza pedrobaeza added this to the 15.0 milestone Nov 24, 2024
@pedrobaeza
Copy link
Member

Please use proper commit message: https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#commit-message

And why removing the module instead of marking it uninstallable?

If the module is uninstallable and module version
exist, we drop it

The default for installable is True
@hhgabelgaard hhgabelgaard force-pushed the 15.0-unlink-uninstallable-modules-hhg branch from eb18ee7 to 92a1368 Compare November 24, 2024 15:14
@hhgabelgaard
Copy link
Author

@pedrobaeza There is no installable/uninstallable flag on odoo.module.version model afaik
And current operation is to only add odoo.module.version records if the addon is installable.
Like when the source is no longer present.
But we could add an installable flag. Or add 'active' field?

Commit message updated

@pedrobaeza pedrobaeza changed the title [IMP] Remove uninstallable module versions if exist [15.0][IMP] github_connector_odoo: Remove uninstallable Nov 25, 2024
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants