[16.0][MIG] connector_ecommerce #75

juliocabrerizo · 2022-10-04T09:50:47Z

Related issue: #74

oca-clabot · 2022-10-04T09:50:50Z

Hey @juliocabrerizo, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: https://odoo-community.org/page/cla
Here is a list of the users:

Arthur Vuillard [email protected] (no github login found)
LuisAdan [email protected] (no github login found)
Brendan Clune [email protected] (no github login found)
Allison Miller [email protected] (no github login found)
sesousy [email protected] (no github login found)
@ <@> (no github login found)

Appreciation of efforts,
OCA CLAbot

[FIX] decimal_precision import does not use openerp.addons namespace

[FIX] fix import

…import

[FIX] remove an old view not installable

[IMP] finish onchange support, add doc string, support tax. The option use external taxe will be not implemented, as re-computing tax in OpenERP is the best option. If you need it, create a independant module for it, fix copyright [REF] refactor introduce the class SaleOrderOnChange

…ork, + support adding extra s.o. lines on the fly add comments on the internals of SaleOrderOnChange.play()

[IMP] work on stock.picking.out instead of stock.picking [REM] clean delivery carrier old code [ADD] a connector hook in the stock.picking.out view [FIX] action_done is not called on stock.picking.out but only on stock.picking [CHG] rename base_sale_data.xml to ecommerce_data.xml [ADD] hook in invoice view for connectors [ADD] account_invoice.origin_order_id, link to the order which created the invoice [REF] moved sale.py code to old_stuff.py [ADD] copy the order id to the invoice it creates [REM] remove code [REF] move content of partner.py to old_stuff.py [REF] move partner_view.xml content to old_xml_stuff.xml [REF] moved code from product.py to old_stuff.py [REF] removed views and act_window links to ir.model.data from sale_view.xml [REF] removed external.referential.category.csv [REF] remove obsolete access groups [REF] comment out the sale exception until its reimplementation [REF] removed the import order wizard [REF] removed connector.py [FIX] style [REF] moved external_referential.py code to old_stuff.py [REF] remove empty files [ADD] hook for connectors in sale view [FIX] do not load removed file [REF] updated __openerp__ manifest, changed copyright attribution to reflect the facts, changed the license from GPL to AGPL-3 [FIX] reintroduce methods used for the import of magento sale orders [FIX] connector_ecommerce: replace dependencies on sale_quick_payment by sale_quick_payment [ADD] connector_ecommerce: add import_rule and days_before_cancel in payment.method, theses fields will be used by the connectors [IMP] connector_ecommerce: call the onchanges on the sale order to apply the workflow default values [IMP] connector_ecommerce: activate the options 'Allow different addresses', 'Multiple shop', 'Discount on SO lines' [FIX] noupdate=1 on the global settings activation [FIX] missing name in a view [IMP] add hints in payment method view to help in the choice of the import rules [ADD] on_product_price_changed Event, fired when the price of a product could have changed As the price is a fields.function based on the contextual pricelist, we can never be sure that a price has changed, it depends on the context. So we search all the base fields used to compute the price, and if one of these has changed, the event is fired. [FIX] initialize the context when None [IMP] reviewed the connector_ecommerce's description in the manifest __openerp__.py [FIX] remove obsolete sale exception [ADD] fields cancelled_in_backend and cancellation_resolved to handle the cancellation of the sales orders from a backend [IMP] add a notification when a user choose to not cancel a sales order cancelled on the backend [ADD] notification when a sales order is cancelled on the backend [IMP] ignore the cancellation from the backend should be done by a sales manager only [IMP] ask for a reason when the sale order is not cancelled despite the cancellation on the backend [FIX] filter on cancels should exclude the resolved cancels [ADD] a parent_id field on the sale order, base implementation, the logic needs to be implemented in the connectors due to their own specificities [ADD] button to open the parent sale order [ADD] sale exception preventing confirmation of a sale order when it has a parent order cancelled on the backend [IMP] add the sales manager rights to the connector manager because they usually need these rights [IMP] fields 'need_cancel' and 'parent_need_cancel' [FIX] spells cancelled with the US form: canceled [FIX] typos in views [FIX] hide the 'keep open' button in canceled state [ADD] when we write 'canceled_in_backend' in a sales order, try to automatically cancel it [FIX] filter out already cancelled sales orders from the filter 'to cancel' [FIX] domain for the invisible attribute of the 'keep open' button, logic was reversed [IMP] add a note on the related pickings and invoices of an order cancelled from backend [FIX] cancelation of sales order: quotation states requires to be canceled via the workflow, sales order states with the action_cancel method. Some states can not be canceled. [ADD] sale exception when an ordered product has a pending connector checkpoint [ADD] french translation

…horized by a payment institute but not paid yet.

… orders (shipping, ...), need a refactoring of the Mapper though. WIP

…ry to store non existing fields in db)

…ne for prestashoperpconnect in a first place to be able to add or not the tax on delivery lines)

[ADD] a test which check if on_invoice_validated is correctly fired [ADD] test the fire of 'on_invoice_paid' [FIX] formatting of the onchange test [FIX] fix the failing test: the payment_method_id and workflow_payment_id are not mandatory in a sale order [FIX] fr_FR.po files not loaded, should be named fr.po [FIX] context not propagated [ADD] docstring [CHG] rename ExtraOrderLineBuilder to SpecialOrderLineBuilder [FIX] use session [ADD] deprecation warning [IMP] allow to use a product id or a product browse_record in lines builders [FIX] Sales Orders onchanges: allow to have lines with other commands than (0, 0, {values}). [FIX] simplify last change [FIX] in lines builders, product_ref is not mandatory if we provide a product, renames 'product_id' to 'product', keeping ambiguity as we can have an int or browse_record. [IMP] propagate the 'shop_id' in the context if it exists so the fiscal position rules (from openerp-fiscal-rules' project) can apply automatically [FIX] 'int' object is not iterable error [FIX] 'int' object is not iterable error, again

…ity by default so they are likely to appear at the bottom, shipping line being the last one

RodrigoBM · 2023-03-10T14:39:01Z

connector_ecommerce/migrations/14.0.1.0.1/post-migration.py

@@ -0,0 +1,7 @@
+from openupgradelib import openupgrade


this directory must be deleted

RodrigoBM · 2023-03-10T15:28:31Z

connector_ecommerce/models/invoice.py

+        return res
+
+    def notify_invoice_validate(self):
+        for record in self.filtered(lambda m: m.move_type == "out_invoice"):


I would change this to

for record in self: if move_type != "out_invoice": continue

RodrigoBM · 2023-03-10T15:31:37Z

connector_ecommerce/models/product.py

+        return result
+
+    @api.model
+    def create(self, vals):


2023-03-10 15:28:49,600 1 WARNING gl_433 odoo.api.create: The model odoo.addons.connector_ecommerce.models.product is not overriding the create method in batch

RodrigoBM · 2023-03-10T15:31:55Z

connector_ecommerce/models/sale.py

+                invoice.message_post(body=message)
+
+    @api.model
+    def create(self, values):


2023-03-10 15:28:49,601 1 WARNING gl_433 odoo.api.create: The model odoo.addons.connector_ecommerce.models.sale is not overriding the create method in batch

RodrigoBM · 2023-03-10T15:54:04Z

connector_ecommerce/models/product.py

+                self._event("on_product_price_changed").notify(product)
+
+    def write(self, vals):
+        result = super(ProductTemplate, self).write(vals)


Apply PEP 3135 (28-Apr-2007) to "super()."

RodrigoBM · 2023-03-10T15:56:29Z

connector_ecommerce/components/line_builder.py

+        self.sequence = 999
+
+    def get_line(self):
+        values = super(ShippingLineBuilder, self).get_line()


Apply PEP 3135 (28-Apr-2007) to "super()."

RodrigoBM · 2023-03-10T15:56:33Z

connector_ecommerce/components/line_builder.py

+    _usage = "order.line.builder.cod"
+
+    def __init__(self, work_context):
+        super(CashOnDeliveryLineBuilder, self).__init__(work_context)


Apply PEP 3135 (28-Apr-2007) to "super()."

RodrigoBM · 2023-03-10T15:56:42Z

connector_ecommerce/components/line_builder.py

+    _usage = "order.line.builder.gift"
+
+    def __init__(self, work_context):
+        super(GiftOrderLineBuilder, self).__init__(work_context)


Apply PEP 3135 (28-Apr-2007) to "super()."

RodrigoBM · 2023-03-10T15:56:45Z

connector_ecommerce/components/line_builder.py

+        self.sequence = 990
+
+    def get_line(self):
+        line = super(GiftOrderLineBuilder, self).get_line()


Apply PEP 3135 (28-Apr-2007) to "super()."

RodrigoBM · 2023-03-10T16:16:50Z

connector_ecommerce/models/product.py

+    def _compute_tax_group_id(self):
+        self.ensure_one()
+        taxes = self.taxes_id
+        self.tax_group_id = taxes[:-1].tax_group_id.id


I think this is not correct, if you can some taxes_id and you make taxes[:-1] get more result.

>>> list_element = [1,2,3,4] >>> list_element[:-1] [1, 2, 3]

and if after you get tax_group_id some element you can get singleton.

>>> self.env["account.tax"].search([]).tax_group_id.id Traceback (most recent call last): File "<console>", line 1, in <module> File "/mnt/environment/odoo-server/odoo/fields.py", line 5035, in __get__ raise ValueError("Expected singleton: %s" % record) ValueError: Expected singleton: account.tax.group(1, 2)

I think the right thing to do is
taxes[-1:].tax_group_id.id

>>> list_element = [1,2,3,4] >>> list_element[-1:] [4] >>> list_element = [] >>> list_element[-1:] []

RodrigoBM · 2023-03-10T22:58:30Z

connector_ecommerce/models/product.py

+
+    @api.model
+    def _price_changed_fields(self):
+        return {"list_price", "lst_price", "standard_price"}


lst_price does not exist in product template

RodrigoBM · 2023-03-10T23:11:27Z

connector_ecommerce/models/product.py

+
+    @api.model
+    def _price_changed_fields(self):
+        return {"lst_price", "standard_price", "price", "price_extra"}


price field dead in V16 May he rest in peace

I would change the return to

@api.model def _price_changed_fields(self): return { "lst_price", "price_extra", } | self.product_tmpl_id._price_changed_fields()

asierneiradev · 2023-03-13T06:32:35Z

Hi @RodrigoBM !

Thank you very much for the suggested changes.

Could you check again the PR proposal ?

Regards

…operation in v16

john-herholz-dt · 2023-04-17T14:30:54Z

@RodrigoBM can you merge this?

OCA-git-bot · 2023-04-17T14:33:10Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

RodrigoBM · 2023-04-17T14:41:50Z

@john-herholz-dt I wish I could, but I have not yet been blessed with that power.

john-herholz-dt · 2023-04-18T09:54:09Z

/ocabot merge

OCA-git-bot · 2023-04-18T09:54:11Z

Hi @john-herholz-dt. Your command failed:

Required option bumpversion_mode for command merge. Possible values : major, minor, patch, nobump.

Ocabot commands

ocabot merge major|minor|patch|nobump
ocabot rebase
ocabot migration {MODULE_NAME}

More information

ocabot documentation
OCA guidelines, specially the "Version Numbers" section.

john-herholz-dt · 2023-04-18T09:55:45Z

/ocabot migration connector_ecommerce

OCA-git-bot · 2023-04-18T09:56:02Z

Sorry @john-herholz-dt you are not allowed to mark the addon tobe migrated.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

john-herholz-dt · 2023-04-18T10:12:07Z

@lmignon can you merge this PR?

lmignon · 2023-04-18T12:16:58Z

/ocabot merge nobump

OCA-git-bot · 2023-04-18T12:17:07Z

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-75-by-lmignon-bump-nobump, awaiting test results.

OCA-git-bot · 2023-04-18T12:23:03Z

Congratulations, your PR was merged at 0c1d739. Thanks a lot for contributing to OCA. ❤️

john-herholz-dt · 2023-04-18T12:24:25Z

Thanks @lmignon you helped a lot with this. I can finally continue using this module for production.

juliocabrerizo changed the title ~~16.0 mig connector ecommerce~~ [16.0][MIG] connector_ecommerce Oct 4, 2022

juliocabrerizo force-pushed the 16.0-mig-connector_ecommerce branch from bd39525 to bc7ad39 Compare October 4, 2022 09:55

juliocabrerizo force-pushed the 16.0-mig-connector_ecommerce branch 2 times, most recently from 42dd416 to 3b42e7a Compare January 24, 2023 08:32

guewen and others added 25 commits January 30, 2023 15:04

[CHG] rename 'base_sale_multichannels' to 'connector_ecommerce'

ca30a6b

[FIX] decimal_precision import does not use openerp.addons namespace

[ADD] Base support to export picking (partial and complete)

fa30301

[FIX] improve styling, remove unused imports, fix license (done by Joel)

2be8130

[FIX] fix import

[ADD] Event to handle the adding of the tracking number on picking

cfe1333

[FIX] remove the carrier tracking number from the event, fix missing …

205ee22

…import

[ADD] Support for exporting the account_invoice to Magento

f664928

[FIX] styling, license, imports, some fixes

b4bf8f8

[FIX] remove an old view not installable

[FIX] add product_view.xml file

ae6237a

[REF] code review

bd8d6fd

[IMP] code review

bbeaa23

[IMP] play on change on sale.order and sale.order.lines in new framew…

a7c40fb

…ork, + support adding extra s.o. lines on the fly add comments on the internals of SaleOrderOnChange.play()

[ADD] 'Authorized' import rules to be able to import sales orders aut…

4c1619a

…horized by a payment institute but not paid yet.

[REF] started to use ConnectorUnit classes to add extra lines in sale…

e9ce90b

… orders (shipping, ...), need a refactoring of the Mapper though. WIP

Fix a bug : remove special fields before database storage (avoid to t…

abdd216

…ry to store non existing fields in db)

[DEL] remove old stuff

5041655

[IMP] - make possible to inherit the method _add_order_extra_line (do…

98c0a1c

…ne for prestashoperpconnect in a first place to be able to add or not the tax on delivery lines)

[FIX] indentation according to pep8

7f559fa

Added "invoice validated" event and called upon "on_invoice_validate".

a60654f

[BUMP] release 2.1.0

ff5d8d8

[IMP] move product_normal_form_view in connector_base_product

68f4e4e

[FIX] product_view.xml in __openerp__.py

f47d0a1

The special sales orders lines can have a sequence and have low prior…

716299e

…ity by default so they are likely to appear at the bottom, shipping line being the last one

asierneiradev mentioned this pull request Mar 9, 2023

Migration to version 16.0 #74

Open

RodrigoBM suggested changes Mar 10, 2023

View reviewed changes

RodrigoBM reviewed Mar 10, 2023

View reviewed changes

RodrigoBM approved these changes Mar 13, 2023

View reviewed changes

asierneiradev force-pushed the 16.0-mig-connector_ecommerce branch 2 times, most recently from 9191596 to 791a828 Compare March 28, 2023 09:06

[16.0][MIG] connector_ecommerce: adapt necessary changes for correct …

6cfac49

…operation in v16

asierneiradev force-pushed the 16.0-mig-connector_ecommerce branch from 791a828 to 6cfac49 Compare March 28, 2023 10:52

RodrigoBM approved these changes Mar 29, 2023

View reviewed changes

john-herholz-dt approved these changes Apr 17, 2023

View reviewed changes

OCA-git-bot added approved ready to merge labels Apr 17, 2023

OCA-git-bot added the bot is merging ⏳ label Apr 18, 2023

OCA-git-bot merged commit 3338eb6 into OCA:16.0 Apr 18, 2023

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Apr 18, 2023

asierneiradev deleted the 16.0-mig-connector_ecommerce branch April 18, 2023 13:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][MIG] connector_ecommerce #75

[16.0][MIG] connector_ecommerce #75

juliocabrerizo commented Oct 4, 2022 •

edited

Loading

oca-clabot commented Oct 4, 2022

RodrigoBM Mar 10, 2023

RodrigoBM Mar 10, 2023

RodrigoBM Mar 10, 2023

RodrigoBM Mar 10, 2023

RodrigoBM Mar 10, 2023

RodrigoBM Mar 10, 2023

RodrigoBM Mar 10, 2023

RodrigoBM Mar 10, 2023

RodrigoBM Mar 10, 2023

RodrigoBM Mar 10, 2023

RodrigoBM Mar 10, 2023

RodrigoBM Mar 10, 2023

asierneiradev commented Mar 13, 2023

john-herholz-dt commented Apr 17, 2023

OCA-git-bot commented Apr 17, 2023

RodrigoBM commented Apr 17, 2023

john-herholz-dt commented Apr 18, 2023

OCA-git-bot commented Apr 18, 2023

john-herholz-dt commented Apr 18, 2023

OCA-git-bot commented Apr 18, 2023

john-herholz-dt commented Apr 18, 2023

lmignon commented Apr 18, 2023

OCA-git-bot commented Apr 18, 2023

OCA-git-bot commented Apr 18, 2023

john-herholz-dt commented Apr 18, 2023

[16.0][MIG] connector_ecommerce #75

[16.0][MIG] connector_ecommerce #75

Conversation

juliocabrerizo commented Oct 4, 2022 • edited Loading

oca-clabot commented Oct 4, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

asierneiradev commented Mar 13, 2023

john-herholz-dt commented Apr 17, 2023

OCA-git-bot commented Apr 17, 2023

RodrigoBM commented Apr 17, 2023

john-herholz-dt commented Apr 18, 2023

OCA-git-bot commented Apr 18, 2023

john-herholz-dt commented Apr 18, 2023

OCA-git-bot commented Apr 18, 2023

john-herholz-dt commented Apr 18, 2023

lmignon commented Apr 18, 2023

OCA-git-bot commented Apr 18, 2023

OCA-git-bot commented Apr 18, 2023

john-herholz-dt commented Apr 18, 2023

juliocabrerizo commented Oct 4, 2022 •

edited

Loading