[16.0][MIG] connector_ecommerce: adapt necessary changes for correct …

…operation in v16

connector_ecommerce/components/line_builder.py

@@ -29,7 +29,7 @@ class SpecialOrderLineBuilder(Component):
     _usage = "order.line.builder"
 
     def __init__(self, work_context):
-        super(SpecialOrderLineBuilder, self).__init__(work_context)
+        super().__init__(work_context)
         self.product = None  # id or browse_record
         # when no product_id, fallback to a product_ref
         self.product_ref = None  # tuple (module, xmlid)
@@ -66,12 +66,12 @@ class ShippingLineBuilder(Component):
     _usage = "order.line.builder.shipping"
 
     def __init__(self, work_context):
-        super(ShippingLineBuilder, self).__init__(work_context)
+        super().__init__(work_context)
         self.product_ref = ("connector_ecommerce", "product_product_shipping")
         self.sequence = 999
 
     def get_line(self):
-        values = super(ShippingLineBuilder, self).get_line()
+        values = super().get_line()
         values["is_delivery"] = True
         return values
 
@@ -84,7 +84,7 @@ class CashOnDeliveryLineBuilder(Component):
     _usage = "order.line.builder.cod"
 
     def __init__(self, work_context):
-        super(CashOnDeliveryLineBuilder, self).__init__(work_context)
+        super().__init__(work_context)
         self.product_ref = ("connector_ecommerce", "product_product_cash_on_delivery")
         self.sequence = 995
 
@@ -97,14 +97,14 @@ class GiftOrderLineBuilder(Component):
     _usage = "order.line.builder.gift"
 
     def __init__(self, work_context):
-        super(GiftOrderLineBuilder, self).__init__(work_context)
+        super().__init__(work_context)
         self.product_ref = ("connector_ecommerce", "product_product_gift")
         self.sign = -1
         self.gift_code = None
         self.sequence = 990
 
     def get_line(self):
-        line = super(GiftOrderLineBuilder, self).get_line()
+        line = super().get_line()
         if self.gift_code:
             line["name"] = "{} [{}]".format(line["name"], self.gift_code)
         return line

connector_ecommerce/components/sale_order_onchange.py

@@ -58,12 +58,7 @@ class SaleOrderOnChange(Component):
     _inherit = "ecommerce.onchange.manager"
     _usage = "ecommerce.onchange.manager.sale.order"
 
-    order_onchange_fields = [
-        "partner_id",
-        "partner_shipping_id",
-        "payment_mode_id",
-        "workflow_process_id",
-    ]
+    order_onchange_fields = ["partner_id"]
 
     line_onchange_fields = ["product_id"]
 
@@ -85,8 +80,7 @@ def play(self, order, order_lines):
         processed_order_lines = []
         line_lists = [order_lines]
         if "order_line" in order and order["order_line"] is not order_lines:
-            # we have both backend-dependent and oerp-native order
-            # lines.
+            # we have both backend-dependent and oerp-native order lines.
             # oerp-native lines can have been added to map
             # shipping fees with an Odoo Product
             line_lists.append(order["order_line"])

connector_ecommerce/models/invoice.py

@@ -12,12 +12,14 @@ def action_post(self):
         self.notify_invoice_validate()
         return res
 
-    def action_invoice_paid(self):
-        res = super().action_invoice_paid()
+    def _invoice_paid_hook(self):
+        res = super()._invoice_paid_hook()
         for record in self:
             self._event("on_invoice_paid").notify(record)
         return res
 
     def notify_invoice_validate(self):
-        for record in self.filtered(lambda m: m.move_type == "out_invoice"):
+        for record in self:
+            if record.move_type != "out_invoice":
+                continue
             self._event("on_invoice_validated").notify(record)

connector_ecommerce/models/product.py

@@ -13,7 +13,7 @@ class ProductTemplate(models.Model):
     def _compute_tax_group_id(self):
         self.ensure_one()
         taxes = self.taxes_id
-        self.tax_group_id = taxes[:-1].tax_group_id.id
+        self.tax_group_id = taxes[-1:].tax_group_id.id
 
     tax_group_id = fields.Many2one(
         comodel_name="account.tax.group",
@@ -50,7 +50,7 @@ def _price_changed(self, vals):
                 self._event("on_product_price_changed").notify(product)
 
     def write(self, vals):
-        result = super(ProductTemplate, self).write(vals)
+        result = super().write(vals)
         self._price_changed(vals)
         return result
 
@@ -60,7 +60,10 @@ class ProductProduct(models.Model):
 
     @api.model
     def _price_changed_fields(self):
-        return {"lst_price", "standard_price", "price", "price_extra"}
+        return {
+            "lst_price",
+            "price_extra",
+        } | self.product_tmpl_id._price_changed_fields()
 
     def _price_changed(self, vals):
         """Fire the ``on_product_price_changed`` if the price
@@ -83,8 +86,9 @@ def write(self, vals):
         self._price_changed(vals)
         return result
 
-    @api.model
-    def create(self, vals):
-        product = super(ProductProduct, self).create(vals)
-        product._price_changed(vals)
-        return product
+    @api.model_create_multi
+    def create(self, vals_list):
+        records = super().create(vals_list)
+        for vals, record in zip(vals_list, records):
+            record._price_changed(vals)
+        return records

connector_ecommerce/models/sale.py

@@ -156,23 +156,24 @@ def _log_canceled_in_backend(self):
             for invoice in order.invoice_ids:
                 invoice.message_post(body=message)
 
-    @api.model
-    def create(self, values):
-        order = super(SaleOrder, self).create(values)
-        if values.get("canceled_in_backend"):
-            order._log_canceled_in_backend()
-            order._try_auto_cancel()
-        return order
+    @api.model_create_multi
+    def create(self, vals_list):
+        records = super().create(vals_list)
+        for vals, record in zip(vals_list, records):
+            if vals.get("canceled_in_backend"):
+                record._log_canceled_in_backend()
+                record._try_auto_cancel()
+        return records
 
     def write(self, values):
-        result = super(SaleOrder, self).write(values)
+        result = super().write(values)
         if values.get("canceled_in_backend"):
             self._log_canceled_in_backend()
             self._try_auto_cancel()
         return result
 
     def action_cancel(self):
-        res = super(SaleOrder, self).action_cancel()
+        res = super().action_cancel()
         for sale in self:
             # the sales order is canceled => considered as resolved
             if sale.canceled_in_backend and not sale.cancellation_resolved:
@@ -219,8 +220,6 @@ def action_view_parent(self):
 
     def _create_delivery_line(self, carrier, price_unit):
         if self.order_line.filtered(lambda r: r.is_delivery):
-            # skip if we have already a delivery line (created by
-            # import of order)
+            # skip if we have already a delivery line (created by import of order)
             return
-        else:
-            return super(SaleOrder, self)._create_delivery_line(carrier, price_unit)
+        return super()._create_delivery_line(carrier, price_unit)

connector_ecommerce/models/stock.py

@@ -14,7 +14,7 @@ class StockPicking(models.Model):
     )
 
     def write(self, vals):
-        res = super(StockPicking, self).write(vals)
+        res = super().write(vals)
         if vals.get("carrier_tracking_ref"):
             for record in self:
                 self._event("on_tracking_number_added").notify(record)

connector_ecommerce/tests/test_invoice_event.py

@@ -11,7 +11,7 @@ class TestInvoiceEvent(common.TransactionCase):
     """Test if the events on the invoice are fired correctly"""
 
     def setUp(self):
-        super(TestInvoiceEvent, self).setUp()
+        super().setUp()
         self.invoice_model = self.env["account.move"]
         partner_model = self.env["res.partner"]
         partner = partner_model.create({"name": "Hodor"})

connector_ecommerce/tests/test_onchange.py

@@ -18,7 +18,7 @@ class TestOnchange(ComponentRegistry):
     """Test if the onchanges are applied correctly on a sales order"""
 
     def setUp(self):
-        super(TestOnchange, self).setUp()
+        super().setUp()
         self.collection = self.env["collection.base"]
         OnChangeManager._build_component(self.comp_registry)
         SaleOrderOnChange._build_component(self.comp_registry)

connector_ecommerce/tests/test_picking_event.py

@@ -26,7 +26,7 @@ def _create_pack_operation(self, product, product_qty, picking_id, **values):
         )
 
     def setUp(self):
-        super(TestPickingEvent, self).setUp()
+        super().setUp()
         self.picking_model = self.env["stock.picking"]
         self.sale_model = self.env["sale.order"]
         self.sale_line_model = self.env["sale.order.line"]