-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mqtt+yaml integration/refactoring #30
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pub and sub mqtt client
Closed
* add can_interface specifier and can configure skip * Update readme with can interface * use clippy suggestions * update minimum argument number checking * make can0 optional
nwdepatie
approved these changes
Jan 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
jr1221
added a commit
that referenced
this pull request
Jun 17, 2024
* Add files via upload pub and sub mqtt client * #22 Refactoring of IPC and Mqtt * #22 Privatize Functions * #22 More Documentation * #22 Even more documentation * #22 And the debugging begins * #22 Debug Update * #22 Added Debug Statement * #22 Remove Thread * #22 Unwrap or Debug * #22 Edit Error Message * #22 Use Stream Instead of Channel * #22 Format Without New Lines * #22 Remove Debug Statements * #22 Date.now * #22 Mqtt Debug Statement * #22 Change publishing topic * #22 Change Topic * #22 Add / * #22 Add 50ms throttle after publish * #22 10ms buffer * #22 1ms throttle * #22 Remove Throttle * #22 Add 1ms throttle back * #22 Lots of General Code Cleanliness And Refactoring * #22 Remove Unused Dependencies * #22 Add Chrono Back * #22 Slight Cleanup * #20 finalize necessary can messages * Filled out Relevant CAN Fields * #20 Write Decode Data to File * #20 Compile * #20 Cleanup Some Linting errors * #20 Disable Clippy * #20 Actually dont allow clippy * #20 Clippy * #20 Delete Unused Files * #20 Seperate Yaml Files * #20 Add Documentation, remove unused dependencies * #20 Adjust can message topic name * Add can_interface specifier and can configure skip (#27) * add can_interface specifier and can configure skip * Update readme with can interface * use clippy suggestions * update minimum argument number checking * make can0 optional --------- Co-authored-by: ihong4 <[email protected]> Co-authored-by: Jack Rubacha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Encompasses all of the changes made to support Both mqtt data offloading, as well as yaml can message descriptions. The goal for this refactoring was to allow for connection to an mqtt server to offload data from the car, as well as a more reliable/consistent form of communication between Calypso and NERO. The Refactoring to yaml was to reduce the amount of developer overhead that went into decoding CAN Messages and easily allow people to see all the can messages being used on the car and easily allow people to add, remove and update CAN messages. The merging of this PR and the validation of the code in testing will mark version 2 of Calypso which should only include the most up to date and relevant code required to have calypso run on the car.