Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.mkdocs-git-committers-plugin-2: init at 2.4.1 #344615

Conversation

mahtaran
Copy link
Contributor

(Same as #343787, renamed branch in my repo. Apologies for spam.)

Description of changes

ojacques/mkdocs-git-committers-plugin-2, primarily used as an optional dependency of Material for MkDocs.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@mahtaran mahtaran requested a review from natsukium as a code owner September 26, 2024 10:11
@mahtaran mahtaran changed the title maintainers: add mahtaran python3Packages.mkdocs-git-committers-plugin-2: init at 2.3.0 Sep 26, 2024
@github-actions github-actions bot added 6.topic: python 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` labels Sep 26, 2024
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Sep 26, 2024
@mahtaran mahtaran changed the title python3Packages.mkdocs-git-committers-plugin-2: init at 2.3.0 python3Packages.mkdocs-git-committers-plugin-2: init at 2.4.1 Oct 6, 2024
@nix-owners nix-owners bot requested a review from natsukium October 8, 2024 23:44
@mahtaran
Copy link
Contributor Author

mahtaran commented Oct 8, 2024

@natsukium thanks for the review! (and apologies for the rookie mistakes.) I believe I have addressed most (if not all) of your concerns, would you mind having another look?

@mahtaran mahtaran force-pushed the package/python3Packages/mkdocs-git-committers-plugin-2 branch from 0324ec9 to fa99aa3 Compare October 20, 2024 16:30
@mahtaran mahtaran force-pushed the package/python3Packages/mkdocs-git-committers-plugin-2 branch from fa99aa3 to 74e6ed7 Compare November 12, 2024 01:22
@mahtaran
Copy link
Contributor Author

Hi @natsukium! I apologize for potentially bothering you, but would it be possible for you to review this again?

@mahtaran mahtaran force-pushed the package/python3Packages/mkdocs-git-committers-plugin-2 branch from 74e6ed7 to c61fc34 Compare November 25, 2024 23:34
@misuzu misuzu dismissed natsukium’s stale review January 3, 2025 15:15

has been addressed

@misuzu misuzu merged commit af26fbc into NixOS:master Jan 3, 2025
31 checks passed
@mahtaran mahtaran deleted the package/python3Packages/mkdocs-git-committers-plugin-2 branch January 10, 2025 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants