Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.mkdocs-material-insiders: init at 9.5.40-insiders-4.53.14 #344616

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mahtaran
Copy link
Contributor

(Same as #343788, renamed branch in my repo. Apologies for spam.)

Insiders version of Material for MkDocs

Depends on #344615

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@mahtaran mahtaran requested a review from natsukium as a code owner September 26, 2024 10:12
@github-actions github-actions bot added 6.topic: python 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` labels Sep 26, 2024
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Sep 26, 2024
@mahtaran mahtaran changed the title python3Packages.mkdocs-material-insiders: init at 9.5.38-insiders-4.53.13 python3Packages.mkdocs-material-insiders: init at 9.5.40-insiders-4.53.14 Oct 10, 2024
@mahtaran mahtaran force-pushed the package/python3Packages/mkdocs-material-insiders branch 2 times, most recently from 45108f1 to 6657d98 Compare October 20, 2024 16:31
@mahtaran mahtaran force-pushed the package/python3Packages/mkdocs-material-insiders branch from 44743a5 to e2d6025 Compare November 12, 2024 01:29
Copy link
Member

@FliegendeWurst FliegendeWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash updates into the init commits. LGTM otherwise

@mahtaran mahtaran force-pushed the package/python3Packages/mkdocs-material-insiders branch from e2d6025 to c5fc87c Compare November 26, 2024 01:37
@mahtaran
Copy link
Contributor Author

Please squash updates into the init commits. LGTM otherwise

Just did so, feel free to have another look!

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 29, 2024
@misuzu

This comment was marked as resolved.

@mahtaran mahtaran force-pushed the package/python3Packages/mkdocs-material-insiders branch from c5fc87c to daf2506 Compare January 10, 2025 21:34
@github-actions github-actions bot removed the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Jan 10, 2025
@mahtaran
Copy link
Contributor Author

@misuzu apologies for taking a little while, but I have just rebased & updated this PR to the latest version of the package!

src = fetchFromGitHub {
owner = "squidfunk";
repo = "mkdocs-material-insiders";
private = true;
Copy link
Contributor

@misuzu misuzu Jan 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imo this package should be in your own repo, we already have mkdocs-material in nixpkgs which can be built by hydra without impure tricks

@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants