-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3Packages.mkdocs-material-insiders: init at 9.5.40-insiders-4.53.14 #344616
base: master
Are you sure you want to change the base?
python3Packages.mkdocs-material-insiders: init at 9.5.40-insiders-4.53.14 #344616
Conversation
45108f1
to
6657d98
Compare
44743a5
to
e2d6025
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please squash updates into the init commits. LGTM otherwise
e2d6025
to
c5fc87c
Compare
Just did so, feel free to have another look! |
This comment was marked as resolved.
This comment was marked as resolved.
c5fc87c
to
daf2506
Compare
@misuzu apologies for taking a little while, but I have just rebased & updated this PR to the latest version of the package! |
src = fetchFromGitHub { | ||
owner = "squidfunk"; | ||
repo = "mkdocs-material-insiders"; | ||
private = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
imo this package should be in your own repo, we already have mkdocs-material in nixpkgs which can be built by hydra without impure tricks
(Same as #343788, renamed branch in my repo. Apologies for spam.)
Insiders version of Material for MkDocs
Depends on #344615
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.