Feature/reenable flasc #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR 191 on FLASC fixed the PyPI upload bug for FLASC, and I've now switched to install FLASC from PyPI. This PR is now ready for merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Undoes #31 to reenable FLASC and makes some minor updates to the lookup-based_wake_steering example.
Waiting as a draft pull request until we address an issue on FLASC that is preventing the latest version of FLASC from being uploaded to PyPI. Once that is done, I intend to add
"flasc~=2.0"to setup.py, in place of the github clone version that is currently there.EDIT: that step is now complete.
Also included in this PR:
FlorisStandinon Hercules."external_signals"key on thehercules_dict.