Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FLASC dependency in LookupBasedWakeSteeringController #32

Closed
misi9170 opened this issue Mar 26, 2024 · 1 comment
Closed

FLASC dependency in LookupBasedWakeSteeringController #32

misi9170 opened this issue Mar 26, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@misi9170
Copy link
Collaborator

As noted in #31 , there are currently dependency conflicts between FLASC and FLORIS. The only reason that FLASC is required in WHOC is for the LookupBasedWakeSteeringController.

Possible solutions:

  • Disable the LookupBasedWakeSteeringController and remove FLASC dependencies ([BUGFIX] Remove dependencies on FLASC temporarily #31 ); then reinstate them when FLASC has been brought up to speed with Floris v4
  • Implement a local solution for get_yaw_angles_interpolant, which is the only functionality imported from FLASC, and make the removal of the dependency on FLASC permanent.
@misi9170 misi9170 added the bug Something isn't working label Mar 26, 2024
@misi9170
Copy link
Collaborator Author

This was addressed in #31 and #35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant