Updated packet class

Mycelium-Server · Feb 18, 2024 · 731e605 · 731e605
1 parent 5fd83d5
commit 731e605
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/Source/Runtime/Core/network/protocol/packet.cpp b/Source/Runtime/Core/network/protocol/packet.cpp
@@ -1,5 +1,3 @@
-
-
 #include "packet.h"
 
 #include <map>

diff --git a/Source/Runtime/Core/network/protocol/packet.h b/Source/Runtime/Core/network/protocol/packet.h
@@ -5,14 +5,20 @@
 #include "../../connection_context.h"
 #include "../byte_buffer.h"
 
-class ServerboundPacket {
+class Packet {
+
+ public:
+  [[nodiscard]] virtual int getPacketID() const = 0;
+};
+
+// TODO: merge into Packet class
+class ServerboundPacket : public Packet {
  public:
   ServerboundPacket();
 
  public:
   virtual void read(ByteBuffer&) = 0;
   virtual ServerboundPacket* createInstance() = 0;
-  [[nodiscard]] virtual int getPacketID() const = 0;
   virtual void handle(ConnectionContext*) = 0;
 
  public:
@@ -22,11 +28,11 @@ class ServerboundPacket {
   static ServerboundPacket* createInstanceFromID(int, ConnectionState);
 };
 
-class ClientboundPacket {
+// TODO: merge into Packet class
+class ClientboundPacket : public Packet {
  public:
   ClientboundPacket();
 
  public:
   virtual void write(ByteBuffer&) = 0;
-  [[nodiscard]] virtual int getPacketID() const = 0;
 };