This repository has been archived by the owner on Sep 26, 2024. It is now read-only.
Connect extension with logged in Credentials #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicoMorenoSirius
changed the title
elg0nz
reviewed
May 21, 2024
| @@ -8,6 +6,16 @@ addEventListener("install", () => { | |||
| }); | |||
| }); | |||
|
|
|||
| // TODO The same login URL should be the cookie URL | |||
| // TODO2 What should we do if user is not logged in? | |||
There was a problem hiding this comment.
If the user is not logged in, you should send them back with an error message. I'll our the designer for mocks
| ], | ||
| "host_permissions": ["<all_urls>"], | ||
| "host_permissions": ["https://*/*", "<all_urls>"], |
There was a problem hiding this comment.
🙏 thanks, this permission stuff always confuses me
elg0nz
approved these changes
May 21, 2024
There was a problem hiding this comment.
LGTM. Re the cookie: we should ask @Luigi-Sirius what he suggests to secure that token :)
| const sendCode = (email: string, code: string) => apiCall('auth/email/complete', { email, code }) | ||
|
|
||
| // TODO see ways to make more secure this cookie... |
There was a problem hiding this comment.
@Luigi-Sirius this is your realm, any thoughts here?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before merging this, the following branches should get merged first:
#6
#7
Both branches are inside this one.