This repository has been archived by the owner on Sep 26, 2024. It is now read-only.
Auth0 integration and Login Success page #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elg0nz
approved these changes
May 21, 2024
| </div> | ||
| <> | ||
| <div className={styles.inputContainer}> | ||
| { |
There was a problem hiding this comment.
Nit: This component is getting pretty packed with logic. It’s fine for now, but if we keep adding features, we might want to think about breaking some of this out into its own component.
I don’t want to mess with the “insertFromPaste,” so feel free to just leave a “TODO” comment for now.
Just keeping an eye on this complexity because React makes it so easy to get these things dirty and unmanageable!
There was a problem hiding this comment.
Yeah you're right. I'll add a TODO comment.
Thanks!
| () => setSubmittedEmail(inputValue), | ||
| () => { | ||
| setSubmittedEmail('') | ||
| // TODO better error showing for the user |
There was a problem hiding this comment.
👍 we'll mention this to our designer.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration between extension and the login token is made here