Fix random test failures on Mac #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralphtheninja
approved these changes
Jul 10, 2022
juliangruber
requested changes
Jul 10, 2022
Using `tempy` to generate random temporary directories results in unix domain socket names that are too long (104 bytes is the max on Mac) which manifests itself as EADDRINUSE errors. So replace `tempy` with a simple alternative. Also expands the CI test matrix, adding Node.js 18 and Windows and Mac, to test platform differences in the handling of sockets.
|
@juliangruber OK, ditched tempy. |
vweevers
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
tempyto generate random temporary directories results in unix domain socket names that are too long (104 bytes is the max on Mac) which manifests itself as EADDRINUSE errors (discovered in #3). So replacetempywith a simple alternative.Also expands the CI test matrix, adding Node.js 18 and Windows and Mac, to test platform differences in the handling of sockets.