Fix random CI failures on Mac

Using `tempy` to generate random temporary directories results in
unix domain socket names that are too long (104 bytes is the max
on Mac) which manifests itself as EADDRINUSE errors. So replace
`tempy` with a simple alternative.

Also expands the CI test matrix, adding Node.js 18 and Windows and
Mac, to test platform differences in the handling of sockets.

.github/workflows/test.yml

@@ -4,11 +4,13 @@ permissions:
   contents: read
 jobs:
   test:
-    runs-on: ubuntu-latest
+    runs-on: ${{ matrix.os }}
     strategy:
+      fail-fast: false
       matrix:
-        node: [12, 14, 16]
-    name: Node ${{ matrix.node }}
+        os: [ubuntu-latest, macos-latest, windows-latest]
+        node: [12, 14, 16, 18]
+    name: Node ${{ matrix.node }} on ${{ matrix.os }}
     steps:
       - name: Checkout
         uses: actions/checkout@v3

test/basic.js

@@ -1,7 +1,7 @@
 'use strict'
 
 const test = require('tape')
-const tempy = require('tempy')
+const tempy = require('./util/tempy')
 const path = require('path')
 const events = require('events')
 const { RaveLevel } = require('..')

test/bytewise.js

@@ -2,7 +2,7 @@
 
 const test = require('tape')
 const bytewise = require('bytewise')
-const tempy = require('tempy')
+const tempy = require('./util/tempy')
 const { RaveLevel } = require('..')
 
 test('bytewise key encoding', function (t) {

test/election.js

@@ -2,7 +2,7 @@
 
 const test = require('tape')
 const { once } = require('events')
-const tempy = require('tempy')
+const tempy = require('./util/tempy')
 const { RaveLevel } = require('..')
 
 test('basic failover', async function (t) {

test/multi-process.js

@@ -1,7 +1,7 @@
 'use strict'
 
 const test = require('tape')
-const tempy = require('tempy')
+const tempy = require('./util/tempy')
 const { once } = require('events')
 const { fork } = require('child_process')
 const { RaveLevel } = require('..')
@@ -14,24 +14,27 @@ if (process.argv[2] === 'child') {
     if (err) throw err
   })
 } else {
-  test('multiple processes', async function (t) {
-    const location = tempy.directory()
-    const entries = []
-    const promises = []
-    const exits = []
+  // Repeat because we have/had random issues here
+  for (let i = 0; i < 20; i++) {
+    test(`multiple processes (${i})`, async function (t) {
+      const location = tempy.directory()
+      const entries = []
+      const promises = []
+      const exits = []
 
-    for (let i = 0; i < 10; i++) {
-      const key = String(i).padStart(5, '0')
-      const value = String(Math.random())
-      const argv = ['child', location, key, value]
-      const child = fork(__filename, argv, { timeout: 30e3 })
+      for (let i = 0; i < 10; i++) {
+        const key = String(i).padStart(5, '0')
+        const value = String(Math.random())
+        const argv = ['child', location, key, value]
+        const child = fork(__filename, argv, { timeout: 30e3 })
 
-      entries.push([key, value])
-      promises.push(once(child, 'exit'))
-      exits.push([0, null])
-    }
+        entries.push([key, value])
+        promises.push(once(child, 'exit'))
+        exits.push([0, null])
+      }
 
-    t.same(await Promise.all(promises), exits)
-    t.same(await new RaveLevel(location).iterator().all(), entries)
-  })
+      t.same(await Promise.all(promises), exits)
+      t.same(await new RaveLevel(location).iterator().all(), entries)
+    })
+  }
 }

test/open-close.js

@@ -2,7 +2,7 @@
 
 const test = require('tape')
 const { once } = require('events')
-const tempy = require('tempy')
+const tempy = require('./util/tempy')
 const { RaveLevel } = require('..')
 
 test('self-flush', async function (t) {

test/sublevel.js

@@ -1,7 +1,7 @@
 'use strict'
 
 const test = require('tape')
-const tempy = require('tempy')
+const tempy = require('./util/tempy')
 const { RaveLevel } = require('..')
 
 test('sublevel', function (t) {

test/util/tempy.js

@@ -0,0 +1,22 @@
+'use strict'
+
+const tempy = require('tempy')
+const path = require('path')
+const crypto = require('crypto')
+const fs = require('fs')
+
+exports.directory = function () {
+  if (process.platform === 'darwin') {
+    // With tempy we'd get a directory like:
+    // /private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/2548920d4cad0629af0e283f78636f1f
+    //
+    // Add to that the 'rave-level.sock' filename and the total length is 105 bytes,
+    // while the maximum length of a unix domain socket on Mac is 104 bytes. Exceeding
+    // it can result in EADDRINUSE errors.
+    const dir = path.join('/tmp', crypto.randomBytes(10).toString('hex'))
+    fs.mkdirSync(dir)
+    return dir
+  } else {
+    return tempy.directory()
+  }
+}