Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bpz-demo-data option to get-data command #55

Merged
merged 2 commits into from
Oct 25, 2023
Merged

Conversation

OliviaLynn
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c768b4a) 97.12% compared to head (51aab75) 97.13%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #55   +/-   ##
=======================================
  Coverage   97.12%   97.13%           
=======================================
  Files          32       32           
  Lines        1671     1673    +2     
=======================================
+ Hits         1623     1625    +2     
  Misses         48       48           
Files Coverage Δ
src/rail/cli/options.py 90.69% <100.00%> (+0.22%) ⬆️
src/rail/cli/scripts.py 89.42% <100.00%> (+0.10%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@eacharles eacharles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good.

have you given thought to how we might expand this as additional data items show up?

@OliviaLynn
Copy link
Member Author

My general plan is that all standard data would go into "data_files." The bpz data is only quarantined as a separate flag because it's dummy data that should very much not be used for anything else.

(While I mention it in the help description of the flag, I realize it would probably be nice to add a comment in the get_data function itself. Just added a new commit.)

Please feel free to let me know if you have a different plan in mind.

@eacharles
Copy link
Collaborator

Ok, makes sense. Thanks

@eacharles eacharles merged commit 069e09d into main Oct 25, 2023
8 checks passed
@OliviaLynn OliviaLynn deleted the user/olynn/bpz-cli branch November 14, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants