Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download tarfile from NERSC #38

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Download tarfile from NERSC #38

merged 2 commits into from
Oct 24, 2023

Conversation

OliviaLynn
Copy link
Member

PR made in preparation of moving the examples into the umbrella notebook (as part of rail #48)

This places the tarfile on NERSC and downloads it with rail get-data --bpz-demo-data (cli option added in rail_base #55), before the existing code to untar and move the files.

(Paths were also shifted a bit because we now download the tar directly into a RAILDIR + "rail/..." path.)

@OliviaLynn OliviaLynn changed the title Lynn/nersc data Download tarfile from NERSC Oct 24, 2023
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (13719c7) 100.00% compared to head (6bcfe80) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #38   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          240       240           
=========================================
  Hits           240       240           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@OliviaLynn OliviaLynn requested a review from sschmidt23 October 24, 2023 21:28
Copy link
Collaborator

@sschmidt23 sschmidt23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and everything works, thanks Olivia

@sschmidt23 sschmidt23 merged commit 6fbbd2a into main Oct 24, 2023
8 checks passed
@sschmidt23 sschmidt23 deleted the lynn/nersc-data branch October 24, 2023 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants