-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ARRR): store unconfirmed change output #2276
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Only one note from my side!
I will wait for the librustzcash
PR to be approved and released first to approve this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Only nits! Don't forget to use the librustzcash release once the PR there is merged then I can re-approve this and merge it.
88bcbd2
to
00e7148
Compare
fixes: #2273
related: KomodoPlatform/librustzcash#10
To Test:
Send a transaction that includes a change output using the entire balance, then attempt to spend/create a new transaction before the initial transaction is confirmed to ensure it is properly tracked in the unspent outputs