Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ARRR): store unconfirmed change output #2276

Merged
merged 7 commits into from
Jan 28, 2025
Merged

fix(ARRR): store unconfirmed change output #2276

merged 7 commits into from
Jan 28, 2025

Conversation

borngraced
Copy link
Member

@borngraced borngraced commented Nov 19, 2024

fixes: #2273
related: KomodoPlatform/librustzcash#10

To Test:

Send a transaction that includes a change output using the entire balance, then attempt to spend/create a new transaction before the initial transaction is confirmed to ensure it is properly tracked in the unspent outputs

@borngraced borngraced self-assigned this Nov 19, 2024
@shamardy shamardy self-requested a review November 25, 2024 10:51
Copy link
Collaborator

@shamardy shamardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Only one note from my side!

I will wait for the librustzcash PR to be approved and released first to approve this.

mm2src/coins/z_coin.rs Outdated Show resolved Hide resolved
mm2src/coins/z_coin/z_htlc.rs Outdated Show resolved Hide resolved
shamardy
shamardy previously approved these changes Dec 6, 2024
Copy link
Collaborator

@shamardy shamardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Only nits! Don't forget to use the librustzcash release once the PR there is merged then I can re-approve this and merge it.

mm2src/coins/z_coin.rs Outdated Show resolved Hide resolved
mm2src/coins/z_coin/z_htlc.rs Outdated Show resolved Hide resolved
@shamardy shamardy merged commit 1416071 into dev Jan 28, 2025
22 of 26 checks passed
@shamardy shamardy deleted the bump-librustzcash branch January 28, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants