use better error naming for save change notes

KomodoPlatform · Dec 10, 2024 · 583de6a · 583de6a
1 parent 3787b93
commit 583de6a
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/mm2src/coins/z_coin.rs b/mm2src/coins/z_coin.rs
@@ -480,7 +480,7 @@ impl ZCoin {
         // and saving them to the wallet database for future spends
         store_change_output(self.consensus_params_ref(), &self.z_fields.light_wallet_db, &tx)
             .await
-            .mm_err(GenTxError::Internal)?;
+            .mm_err(GenTxError::SaveChangeNotesError)?;
 
         let additional_data = AdditionalTxData {
             received_by_me,

diff --git a/mm2src/coins/z_coin/z_coin_errors.rs b/mm2src/coins/z_coin/z_coin_errors.rs
@@ -130,6 +130,7 @@ pub enum GenTxError {
     FailedToCreateNote,
     SpendableNotesError(String),
     Internal(String),
+    SaveChangeNotesError(String),
 }
 
 impl From<GetUnspentWitnessErr> for GenTxError {
@@ -176,8 +177,9 @@ impl From<GenTxError> for WithdrawError {
             | GenTxError::BlockchainScanStopped
             | GenTxError::LightClientErr(_)
             | GenTxError::SpendableNotesError(_)
-            | GenTxError::FailedToCreateNote => WithdrawError::InternalError(gen_tx.to_string()),
-            GenTxError::Internal(_) => WithdrawError::InternalError(gen_tx.to_string()),
+            | GenTxError::FailedToCreateNote
+            | GenTxError::Internal(_)
+            | GenTxError::SaveChangeNotesError(_) => WithdrawError::InternalError(gen_tx.to_string()),
         }
     }
 }

diff --git a/mm2src/coins/z_coin/z_htlc.rs b/mm2src/coins/z_coin/z_htlc.rs
@@ -195,7 +195,7 @@ pub async fn z_p2sh_spend(
     // and saving them to the wallet database for future spends
     store_change_output(coin.consensus_params_ref(), &coin.z_fields.light_wallet_db, &zcash_tx)
         .await
-        .mm_err(|err| ZP2SHSpendError::GenTxError(GenTxError::Internal(err)))?;
+        .mm_err(|err| ZP2SHSpendError::GenTxError(GenTxError::SaveChangeNotesError(err)))?;
 
     coin.utxo_rpc_client()
         .send_raw_transaction(tx_buffer.into())