mas 1.9.0 #203180
Merged
mas 1.9.0 #203180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes required build changes for mas 1.9.0: 1) Pass `homebrew/core/mas` as an argument for `script/build` to indicate that mas was installed from Homebrew core, so it can be reported by the new `mas config` command. 2) `brew test-bot --only-formulae` leaves a dirty working tree, which will now cause mas to append a `+` to its version, which is useful when switching between multiple `mas` executables during development. The build now accepts a new `MAS_DIRTY_INDICATOR` environment variable whose value replaces the `+`. The build assigns an empty string to ensure the version has no suffix. Signed-off-by: Ross Goldberg <[email protected]>
Closed
|
🤖 An automated task has requested bottles to be published to this PR. |
github-actions
bot
added
the
CI-published-bottle-commits
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am a maintainer of mas.
The changes in this PR are necessary for the
masformula to build 1.9.0 properly.Someone else opened a bump PR #203170. That will not build. Please close it.
Required build changes for mas 1.9.0:
Pass
homebrew/core/masas an argument forscript/buildto indicate that mas was installed from Homebrew core, so it can be reported by the newmas configcommand.brew bump-formula-pr …has a dirty working tree, which now causes mas to append a+to its version, which, while useful when switching between multiplemasexecutables during development, breaks the attempted bump.The build now accepts a new
MAS_DIRTY_INDICATORenvironment variable whose value replaces the+. The build assigns an empty string to ensure the version has no suffix.HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?