Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mas 1.9.0 #203170

Closed
wants to merge 1 commit into from
Closed

mas 1.9.0 #203170

wants to merge 1 commit into from

Conversation

ik11235
Copy link
Contributor

@ik11235 ik11235 commented Jan 4, 2025

Created by brew bump


Created with brew bump-formula-pr.

@github-actions github-actions bot added bump-formula-pr PR was created using `brew bump-formula-pr` macos-only Formula depends on macOS labels Jan 4, 2025
@rgoldberg rgoldberg mentioned this pull request Jan 4, 2025
6 tasks
@rgoldberg
Copy link
Contributor

I am a maintainer of mas.

Please close this PR.

I opened #203180 to update mas to 1.9.0.

That includes necessary changes to the formula to build 1.9.0.

@ik11235 Thanks for trying to help out by bumping the formula, but please don't bump mas anymore in the future.

Our new release process automatically runs brew bump-formula-pr <many options…> mas. For 1.9.0, we ran into an unexpected Homebrew issue that prevented bottles from building, so our bump didn't go through, and you bumped before we fixed the issue. Thanks for trying to help, but it just gets in the way of our release process.

@daeho-ro daeho-ro closed this Jan 4, 2025
@ik11235
Copy link
Contributor Author

ik11235 commented Jan 4, 2025

@rgoldberg

Sure.

I ran that process because I thought I could update it with bump-formula-pr, as you mentioned.
However, we have come to understand that this will ultimately hinder your release work.

I will be careful not to run bump-formula-pr against mas in the future.
Sorry for the hassle.

@ik11235 ik11235 deleted the bump-mas-1.9.0 branch January 4, 2025 10:01
@rgoldberg
Copy link
Contributor

@ik11235 No problem. You were just trying to help. Thanks for understanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` macos-only Formula depends on macOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants