Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Solstice Client :latest #46215

Closed
wants to merge 2 commits into from
Closed

Add Solstice Client :latest #46215

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
88c133e
Add Solstice Client :latest
iandrewt Apr 22, 2018
4c27925
Update solstice.rb
commitay Apr 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions Casks/solstice.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
cask 'solstice' do
version :latest
sha256 :no_check

url 'https://www.mersive.com/downloads/SolsticeClientMacWeb.zip'
name 'Solstice Client'
homepage 'https://www2.mersive.com/'

installer manual: 'SolsticeClientMacWeb.app'

uninstall delete: '~/Desktop/Solstice Client.app'
Copy link
Member

@vitorgalvao vitorgalvao Apr 23, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s unlikely moving this app is the only thing the installer does. Furthermore, it’s unlikely users will keep the installed app in their Desktop.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it’s unlikely users will keep the installed app in their Desktop

There isn't much we can do about this. It runs a GUI installer that doesn't seem to accept any flags so we can't move it ourselves.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There isn't much we can do about this.

We can postflight to move it to appdir.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a GUI installer?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, right. Still, deleting it from the Desktop is bound to be useless. This would be another good candidate for #8211.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we refuse it then?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, depending on what @iandrewt can gather, if anything. For all we know this might setup an uninstall script in a fixed location that would acceptably deal with the matter.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, sorry I've been inactive since submitting this. Did some testing, moving the app from the desktop to Applications doesn't result in it being moved back when opening it again. Is this the kind of info you're after?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, the issue is that since this has an installer (as opposed to just a .app bundle) it likely does some modifications to your system (like installing launchd jobs). For this to be accepted, we need to have an uninstall that undos those changes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, did some digging and it looks like the only other file system thing it does is create a couple files in ~/Library/Application Support (the file solsticeMRU_V2.dat and the folder Solstice). Nothing at all in /Library, and no launchd jobs

end