-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Solstice Client :latest #46215
Add Solstice Client :latest #46215
Conversation
Adds Solstice client, an app used for mirroring the display to a TV in education/enterprise
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need further documentation on this app’s un/install process. As it is, we cannot accept this cask.
|
||
installer manual: 'SolsticeClientMacWeb.app' | ||
|
||
uninstall delete: '~/Desktop/Solstice Client.app' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It’s unlikely moving this app is the only thing the installer does. Furthermore, it’s unlikely users will keep the installed app in their Desktop.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it’s unlikely users will keep the installed app in their Desktop
There isn't much we can do about this. It runs a GUI installer that doesn't seem to accept any flags so we can't move it ourselves.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There isn't much we can do about this.
We can postflight
to move it to appdir
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a GUI installer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, right. Still, deleting it from the Desktop is bound to be useless. This would be another good candidate for #8211.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we refuse it then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, depending on what @iandrewt can gather, if anything. For all we know this might setup an uninstall script in a fixed location that would acceptably deal with the matter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, sorry I've been inactive since submitting this. Did some testing, moving the app from the desktop to Applications doesn't result in it being moved back when opening it again. Is this the kind of info you're after?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, the issue is that since this has an installer (as opposed to just a .app bundle) it likely does some modifications to your system (like installing launchd
jobs). For this to be accepted, we need to have an uninstall
that undos those changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, did some digging and it looks like the only other file system thing it does is create a couple files in ~/Library/Application Support
(the file solsticeMRU_V2.dat
and the folder Solstice
). Nothing at all in /Library
, and no launchd
jobs
Going to refuse since we can’t build a proper uninstall. Still, thank you for the contribution and the fast responses. |
Adds Solstice client, an app used for mirroring the display to a TV in education/enterprise