vkd3d: enable ds<->color copies using maintenance8 #2314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doitsujin
reviewed
Jan 27, 2025
There was a problem hiding this comment.
Style nit.
As for what Hans-Kristian said, I'm not sure off the top of my head if something like D32->RGBA8 is legal or not. In D3D11 it definitely is, but at the same time I don't think our current fallback even supports that anyway.
I also don't think we should ever encounter D24S8 here, D3D12 largely treats depth-stencil as multi-planar and CopyResource doesn't allow mismatched formats, so if there's an aspect mismatch here we should only ever have one single aspect set on each subresource range.
this avoids renderpass copies for allowed formats, though only DIRECT/GRAPHICS queue is supported by maintenance8 Signed-off-by: Mike Blumenkrantz <[email protected]>
HansKristian-Work
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this avoids renderpass copies for allowed formats, though only DIRECT/GRAPHICS queue is supported by maintenance8