Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More general organisation and fixes #604

Merged
merged 29 commits into from
Jan 29, 2025

Remove unused imports

00e94bd
Select commit
Loading
Failed to load commit list.
Merged

More general organisation and fixes #604

Remove unused imports
00e94bd
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 28, 2025 in 0s

35.07% (+0.17%) compared to 9257c97

View this Pull Request on Codecov

35.07% (+0.17%) compared to 9257c97

Details

Codecov Report

Attention: Patch coverage is 48.17814% with 256 lines in your changes missing coverage. Please review.

Project coverage is 35.07%. Comparing base (9257c97) to head (00e94bd).

Files with missing lines Patch % Lines
...tent/entity/player/command/debug/DebugCommands.kts 0.00% 18 Missing ⚠️
...voidps/engine/entity/item/floor/FloorItemOption.kt 0.00% 14 Missing ⚠️
.../main/kotlin/content/skill/prayer/active/Leech.kts 20.00% 8 Missing and 4 partials ⚠️
...tent/entity/player/command/admin/AdminCommands.kts 0.00% 11 Missing ⚠️
...ain/kotlin/content/skill/magic/spell/SpellRunes.kt 92.85% 1 Missing and 9 partials ⚠️
...ntent/area/misthalin/lumbridge/LumbridgeChurch.kts 0.00% 8 Missing ⚠️
.../kotlin/content/area/misthalin/varrock/Delrith.kts 0.00% 8 Missing ⚠️
game/src/main/kotlin/content/skill/melee/Block.kts 38.46% 4 Missing and 4 partials ⚠️
.../gregs/voidps/engine/suspend/SuspendableContext.kt 12.50% 7 Missing ⚠️
...content/skill/melee/weapon/special/KorasiSword.kts 0.00% 7 Missing ⚠️
... and 74 more
Additional details and impacted files
Files with missing lines Coverage Δ
...tlin/world/gregs/voidps/engine/entity/item/Item.kt 56.52% <100.00%> (ø)
.../world/gregs/voidps/engine/queue/ActionPriority.kt 100.00% <ø> (ø)
...kotlin/content/area/asgarnia/port_sarim/Thurgo.kts 3.96% <100.00%> (ø)
...n/kotlin/content/area/asgarnia/taverley/Sanfew.kts 7.05% <100.00%> (ø)
...andarin/barbarian_outpost/BarbarianOutpostGate.kts 60.00% <100.00%> (ø)
...n/content/area/wilderness/abyss/AbyssObstacles.kts 97.26% <100.00%> (ø)
...n/kotlin/content/entity/combat/hit/CombatAttack.kt 92.85% <ø> (ø)
...n/kotlin/content/entity/combat/hit/CombatDamage.kt 92.59% <100.00%> (ø)
...e/src/main/kotlin/content/entity/combat/hit/Hit.kt 66.66% <100.00%> (ø)
...c/main/kotlin/content/entity/death/PlayerDeath.kts 54.36% <100.00%> (ø)
... and 95 more

... and 6 files with indirect coverage changes

@@             Coverage Diff              @@
##               main     #604      +/-   ##
============================================
+ Coverage     34.90%   35.07%   +0.17%     
- Complexity     4889     4922      +33     
============================================
  Files          1339     1343       +4     
  Lines         47120    47181      +61     
  Branches       9502     9506       +4     
============================================
+ Hits          16445    16549     +104     
+ Misses        27294    27231      -63     
- Partials       3381     3401      +20
Components Coverage Δ
Content 28.94% <50.75%> (+0.33%) ⬆️
Engine 43.45% <6.89%> (-0.05%) ⬇️
Network 71.85% <ø> (ø)
View more details on Codecov